PageStorage: Fix tiflash wn oom issue by introducing DeltaTreeOnlySnapshot#10410
Merged
ti-chi-bot[bot] merged 14 commits intopingcap:masterfrom Sep 9, 2025
Merged
PageStorage: Fix tiflash wn oom issue by introducing DeltaTreeOnlySnapshot#10410ti-chi-bot[bot] merged 14 commits intopingcap:masterfrom
ti-chi-bot[bot] merged 14 commits intopingcap:masterfrom
Conversation
9d79ee9 to
8f88fc9
Compare
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
5478317 to
aafdf08
Compare
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
…ogic Signed-off-by: JaySon-Huang <tshent@qq.com>
aafdf08 to
dd17d4a
Compare
Contributor
Author
|
/test all |
Contributor
Author
|
/test all |
Contributor
Author
|
/test all |
Contributor
|
/retest |
JinheLin
approved these changes
Sep 9, 2025
Contributor
Author
|
/hold |
Signed-off-by: JaySon-Huang <tshent@qq.com>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CalvinNeo, JinheLin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
df87b7a to
152dda9
Compare
Signed-off-by: JaySon-Huang <tshent@qq.com>
Contributor
Author
|
/unhold |
Member
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot
pushed a commit
to ti-chi-bot/tiflash
that referenced
this pull request
Sep 19, 2025
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
12 tasks
ti-chi-bot bot
pushed a commit
that referenced
this pull request
Sep 22, 2025
…pshot (#10410) (#10448) close #10278, close #10382 * UniversalPageStorage Provide two kinds of snapshot * GeneralSnapshot: protect all data, used for general-purpose reading on UniversalPageStorage * DeltaTreeOnlySnapshot: protect only data in DeltaTree engine, used for handling reading requests * UniversalPageStorage GC * The page_ids from raft layer is not protected by `DeltaTreeOnlySnapshot` * If the page_id is from raft layer and there is no general snapshot, clean up entries more aggressively to reduce memory usage. * WriteNode snapshot GC * The write node snapshot timeout is defined by compute node `EstablishDisaggTaskRequest` * The default snapshot timeout increase from 5 minutes to 30 minutes Signed-off-by: JaySon-Huang <tshent@qq.com> Co-authored-by: JaySon-Huang <tshent@qq.com> Co-authored-by: JaySon <tshent@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #10382, close #10278
Problem Summary:
Slow query requests prevent the release of PageStorage snapshots, causing persistent issues where multi-versioned data in PageStorage memory and multi-versioned columnar storage data on disk cannot be compacted. However, under the storage-compute separation architecture, TiFlash aims to support the capability of restoring new Region replicas from S3 , which motivates storing high-frequency write-and-delete data such as RaftLog into PageStorage. As a result, with Raft messages sustained at 12K QPS, a 10-minute-long query causes the number of Pages in PageStorage to increase by 7.2 million and the number of multi-versions to rise by 17.8 million. Due to the design of PageStorage, this leads to an additional 6 GB of memory consumption, and may also be accompanied by degraded read and write performance in PageStorage.
What is changed and how it works?
Manual Testing result
According to the test result
Check List
Tests
described as above
Side effects
Documentation
Release note