Storage: Cleanup StoragePool interface#10411
Merged
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom Sep 8, 2025
Merged
Conversation
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
fa8b075 to
68fc0ab
Compare
Lloyd-Pottiger
approved these changes
Sep 8, 2025
JinheLin
approved these changes
Sep 8, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JinheLin, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
[LGTM Timeline notifier]Timeline:
|
JaySon-Huang
added a commit
to ti-chi-bot/tiflash
that referenced
this pull request
Sep 22, 2025
ref pingcap#6233 Storage: Cleanup StoragePool interface * Remove useless newLogReader interface from StoragePool * Remove useless always true `snapshot_read` param from StorageSnapshot * Refine unit tests of PageStorageMixedTest Signed-off-by: JaySon-Huang <tshent@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #6233
Problem Summary:
The function
PageReaderPtr newLogReader(ReadLimiterPtr read_limiter, PageStorageSnapshotPtr & snapshot);is somehow duplicated withPageReaderPtr newLogReader(ReadLimiterPtr read_limiter, bool snapshot_read, const String & tracing_id);. It is confusing and increase the code complexity, and make testing more confusing.What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note