Skip to content

Support graceful shutdown in WN#10430

Merged
ti-chi-bot[bot] merged 6 commits intopingcap:masterfrom
gengliqi:graceful-shutdown-disagg
Sep 17, 2025
Merged

Support graceful shutdown in WN#10430
ti-chi-bot[bot] merged 6 commits intopingcap:masterfrom
gengliqi:graceful-shutdown-disagg

Conversation

@gengliqi
Copy link
Contributor

@gengliqi gengliqi commented Sep 15, 2025

What problem does this PR solve?

Issue Number: ref #10266, close #10425

Problem Summary:

What is changed and how it works?

Support graceful shutdown in WN

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Signed-off-by: gengliqi <gengliqiii@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 15, 2025
u
Signed-off-by: gengliqi <gengliqiii@gmail.com>
u
Signed-off-by: gengliqi <gengliqiii@gmail.com>
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a comment

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 16, 2025
Signed-off-by: gengliqi <gengliqiii@gmail.com>
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@JaySon-Huang
Copy link
Contributor

/test pull-unit-test

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 17, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 17, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-09-16 09:32:34.130930555 +0000 UTC m=+958620.690812052: ☑️ agreed by JaySon-Huang.
  • 2025-09-17 06:36:26.839501851 +0000 UTC m=+1034453.399383348: ☑️ agreed by JinheLin.

@JaySon-Huang
Copy link
Contributor

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 17, 2025
u
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@gengliqi gengliqi force-pushed the graceful-shutdown-disagg branch from 4d986bb to a740e82 Compare September 17, 2025 06:48
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, JinheLin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,JinheLin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JaySon-Huang
Copy link
Contributor

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 17, 2025
@ti-chi-bot ti-chi-bot bot merged commit ff34ccc into pingcap:master Sep 17, 2025
7 checks passed
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Sep 17, 2025
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #10438.
But this PR has conflicts, please resolve them!

ti-chi-bot bot pushed a commit that referenced this pull request Sep 18, 2025
ref #10266, close #10425

Support graceful shutdown in WN

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: gengliqi <gengliqiii@gmail.com>

Co-authored-by: Liqi Geng <gengliqiii@gmail.com>
Co-authored-by: gengliqi <gengliqiii@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[next gen] enhance graceful shutdown ability on tiflash write node

4 participants