Skip to content

Support graceful shutdown in WN (#10430)#10438

Merged
ti-chi-bot[bot] merged 2 commits intopingcap:release-8.5from
ti-chi-bot:cherry-pick-10430-to-release-8.5
Sep 18, 2025
Merged

Support graceful shutdown in WN (#10430)#10438
ti-chi-bot[bot] merged 2 commits intopingcap:release-8.5from
ti-chi-bot:cherry-pick-10430-to-release-8.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Sep 17, 2025

This is an automated cherry-pick of #10430

What problem does this PR solve?

Issue Number: ref #10266, close #10425

Problem Summary:

What is changed and how it works?

Support graceful shutdown in WN

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@gengliqi @ti-chi-bot
This is an automated cherry-pick of pingcap#10430
e01fdc9 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Sep 17, 2025
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 17, 2025
Merged
12 tasks
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Sep 17, 2025

@gengliqi This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 17, 2025

@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@gengliqi
fix conflicts
e6108c0 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Sep 17, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gengliqi, JaySon-Huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,gengliqi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 18, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 18, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-09-17 12:54:21.449019064 +0000 UTC m=+18022.927599710: ☑️ agreed by gengliqi.
  • 2025-09-18 04:53:18.659328939 +0000 UTC m=+75560.137909586: ☑️ agreed by JaySon-Huang.

@JaySon-Huang JaySon-Huang removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 18, 2025
@ti-chi-bot ti-chi-bot bot merged commit 206d944 into pingcap:release-8.5 Sep 18, 2025
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the cherry-pick-10430-to-release-8.5 branch September 18, 2025 04:58
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. and removed cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/cherry-pick-not-approved labels Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@gengliqi gengliqi gengliqi approved these changes

Assignees

@gengliqi gengliqi

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ti-chi-bot @JaySon-Huang @gengliqi