Reduce redundant pack reads during building bitmap filter for delta merge case (release-8.5)#10293
Merged
ti-chi-bot[bot] merged 17 commits intopingcap:release-8.5from Sep 27, 2025
Merged
Conversation
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Contributor
Author
|
/test pull-unit-test |
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
close pingcap#9866 Co-authored-by: JaySon <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: gengliqi <gengliqiii@gmail.com>
Closed
12 tasks
Contributor
Author
|
/hold |
Signed-off-by: gengliqi <gengliqiii@gmail.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Lloyd-Pottiger
approved these changes
Sep 26, 2025
JinheLin
approved these changes
Sep 26, 2025
Contributor
[LGTM Timeline notifier]Timeline:
|
Contributor
|
Before: dbd76e7 mysql> select TIDB_TABLE, sum(DELTA_MEMTABLE_ROWS+DELTA_PERSISTED_ROWS) delta_rows, sum(stable_rows) stable_rows from INFORMATION_SCHEMA.TIFLASH_SEGMENTS where TIDB_DATABASE='chbench_delta' group by TIDB_TABLE order by stable_rows, delta_rows;
+------------+------------+-------------+
| TIDB_TABLE | delta_rows | stable_rows |
+------------+------------+-------------+
| region | 10 | 0 |
| nation | 50 | 0 |
| district | 30000 | 0 |
| supplier | 36384 | 0 |
| warehouse | 2712 | 288 |
| item | 0 | 200000 |
| new_order | 200772 | 26917020 |
| orders | 1136056 | 89873752 |
| customer | 1683216 | 89931328 |
| history | 917957 | 89987264 |
| stock | 4821696 | 296328727 |
| order_line | 22772241 | 880956623 |
+------------+------------+-------------+
12 rows in set (0.09 sec)
mysql> select sum(DELTA_MEMTABLE_ROWS+DELTA_PERSISTED_ROWS) delta_rows, sum(stable_rows) stable_rows, 100 * sum(DELTA_MEMTABLE_ROWS+DELTA_PERSISTED_ROWS) / sum(stable_rows) delta_percent from INFORMATION_SCHEMA.TIFLASH_SEGMENTS where
TIDB_DATABASE='chbench_delta';
+------------+-------------+---------------+
| delta_rows | stable_rows | delta_percent |
+------------+-------------+---------------+
| 31601094 | 1474195002 | 2.1436 |
+------------+-------------+---------------+
1 row in set (0.08 sec)Overall 27% ImprovementBasically the same as the test results of #9876.
|
gengliqi
approved these changes
Sep 26, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gengliqi, JinheLin, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
Waiting for the internal end-2-end consistency-workload testing: https://tcms.pingcap.net/dashboard/executions/plan/7938394 |
Contributor
Author
|
/unhold The internal testing passed without issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pick #9876 and a part of #9738 to release-8.5
What problem does this PR solve?
Issue Number: close #9875
Problem Summary:
According to #9876, this would gain overall 26.5% Improvement on CHBenchmark 1500 with update workloads.
What is changed and how it works?
The performance benchmark on release-8.5, overall 27% Improvement #10293 (comment)
Check List
Tests
Side effects
Documentation
Release note