Skip to content

UnitTest SegmentReadTaskTest.InitInputStream does not meet expectations #9866

New issue
New issue
Closed
#9867
Closed
UnitTest SegmentReadTaskTest.InitInputStream does not meet expectations#9866
#9867
Assignees
JinheLin
Labels
component/storageseverity/moderatetype/bugThe issue is confirmed as a bug.
@JinheLin

Description

@JinheLin
JinheLin
opened on Feb 12, 2025

tiflash/dbms/src/Storages/DeltaMerge/tests/gtest_segment_read_task.cpp

Lines 124 to 137 in 4ffbd35

task->initInputStream(column_defines, 0, nullptr, ReadMode::Bitmap, DEFAULT_BLOCK_SIZE, true);
auto stream = task->getInputStream();
ASSERT_NE(stream, nullptr);
std::vector<Block> blks;
for (auto blk = stream->read(); blk; blk = stream->read())
{
blks.push_back(blk);
}
auto handle_col1 = vstackBlocks(std::move(blks)).getByName(MutSup::extra_handle_column_name).column;
auto handle_col2 = getSegmentHandle(task->segment->segmentId(), {task->segment->getRowKeyRange()});
ASSERT_TRUE(sequenceEqual(
toColumnVectorDataPtr<Int64>(handle_col2)->data(),
toColumnVectorDataPtr<Int64>(handle_col1)->data(),
handle_col1->size()));

  • In L124, used 0 as the parameter for start_ts, resulting in an empty read result.
  • In L134~L137, sequenceEqual not checking the size of the two sequences. Since handle_col1->size() is 0, this is equivalent to skipping the check of two sequences.

Metadata

Metadata

Assignees

Labels

component/storageseverity/moderatetype/bugThe issue is confirmed as a bug.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions