Skip to content

Fix incorrect conversion of column to nullable in Expand operator#10116

Merged
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
gengliqi:fix-expand-schema
Apr 17, 2025
Merged

Fix incorrect conversion of column to nullable in Expand operator#10116
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
gengliqi:fix-expand-schema

Conversation

@gengliqi
Copy link
Contributor

@gengliqi gengliqi commented Apr 17, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #10110

Problem Summary:
See #10110

What is changed and how it works?

Fix incorrect conversion of column to nullable in Expand operator

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix incorrect conversion of column to nullable in Expand operator

gengliqi added 2 commits April 17, 2025 11:52
@gengliqi
fix
771b338 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@gengliqi
add integration tests
c9624e2 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@ti-chi-bot ti-chi-bot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 17, 2025
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 17, 2025
gengliqi added 2 commits April 17, 2025 17:13
@gengliqi
Merge branch 'master' into fix-expand-schema
8cff3f7
@gengliqi
update tests
71698d5 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
windtalker
windtalker approved these changes Apr 17, 2025
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 17, 2025
xzhangxian1008
xzhangxian1008 approved these changes Apr 17, 2025
View reviewed changes
Copy link
Contributor

@xzhangxian1008 xzhangxian1008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, xzhangxian1008

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 17, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 17, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-04-17 09:29:13.501918485 +0000 UTC m=+2939847.186154581: ☑️ agreed by windtalker.
  • 2025-04-17 09:29:41.708868019 +0000 UTC m=+2939875.393104115: ☑️ agreed by xzhangxian1008.

@ti-chi-bot ti-chi-bot bot merged commit d0734b7 into pingcap:master Apr 17, 2025
5 checks passed
@gengliqi gengliqi added needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. affects-9.0 This bug affects the 9.0.x versions. needs-cherry-pick-release-9.0-beta.1 and removed affects-9.0 This bug affects the 9.0.x versions. needs-cherry-pick-release-9.0-beta.1 labels Apr 17, 2025
@gengliqi
Copy link
Contributor Author

gengliqi commented Apr 17, 2025

/run-cherry-picker

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 17, 2025
Merged
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 17, 2025

In response to a cherrypick label: new pull request created to branch release-7.5: #10117.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 17, 2025

In response to a cherrypick label: new pull request created to branch release-8.1: #10118.

This was referenced Apr 17, 2025
Merged
Merged
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 17, 2025

In response to a cherrypick label: new pull request created to branch release-8.5: #10119.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 17, 2025

In response to a cherrypick label: new pull request created to branch release-9.0-beta.1: #10120.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 17, 2025
Closed
12 tasks
@gengliqi
Copy link
Contributor Author

gengliqi commented Apr 18, 2025

/cherrypick release-8.5-20250418-v8.5.1

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 18, 2025

@gengliqi: new pull request created to branch release-8.5-20250418-v8.5.1: #10121.

Details

In response to this:

/cherrypick release-8.5-20250418-v8.5.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 18, 2025
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Apr 18, 2025
@ti-chi-bot @gengliqi
Fix incorrect conversion of column to nullable in Expand operator (#1…
06d5c94 
…0116) (#10121)

close #10110

Fix incorrect conversion of column to nullable in Expand operator

Signed-off-by: gengliqi <gengliqiii@gmail.com>

Co-authored-by: gengliqi <gengliqiii@gmail.com>
ti-chi-bot bot pushed a commit that referenced this pull request Apr 21, 2025
@ti-chi-bot @gengliqi
Fix incorrect conversion of column to nullable in Expand operator (#1…
c6cdf58 
…0116) (#10119)

close #10110

Fix incorrect conversion of column to nullable in Expand operator

Signed-off-by: gengliqi <gengliqiii@gmail.com>

Co-authored-by: gengliqi <gengliqiii@gmail.com>
ti-chi-bot bot pushed a commit that referenced this pull request Apr 23, 2025
@ti-chi-bot @gengliqi
Fix incorrect conversion of column to nullable in Expand operator (#1…
cc8ebb2 
…0116) (#10118)

close #10110

Fix incorrect conversion of column to nullable in Expand operator

Signed-off-by: gengliqi <gengliqiii@gmail.com>

Co-authored-by: gengliqi <gengliqiii@gmail.com>
ti-chi-bot bot pushed a commit that referenced this pull request Apr 23, 2025
@ti-chi-bot @gengliqi
Fix incorrect conversion of column to nullable in Expand operator (#1…
76d743b 
…0116) (#10117)

close #10110

Fix incorrect conversion of column to nullable in Expand operator

Signed-off-by: gengliqi <gengliqiii@gmail.com>

Co-authored-by: gengliqi <gengliqiii@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@windtalker windtalker windtalker approved these changes

+1 more reviewer

@xzhangxian1008 xzhangxian1008 xzhangxian1008 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Expand operator may incorrectly convert column to nullable, causing exceptions or crashes

4 participants

@gengliqi @ti-chi-bot @windtalker @xzhangxian1008