Skip to content

Fix incorrect conversion of column to nullable in Expand operator (#10116)#10120

Closed
ti-chi-bot wants to merge 3 commits intopingcap:release-9.0-beta.1from
ti-chi-bot:cherry-pick-10116-to-release-9.0-beta.1
Closed

Fix incorrect conversion of column to nullable in Expand operator (#10116)#10120
ti-chi-bot wants to merge 3 commits intopingcap:release-9.0-beta.1from
ti-chi-bot:cherry-pick-10116-to-release-9.0-beta.1

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Apr 17, 2025

This is an automated cherry-pick of #10116

What problem does this PR solve?

Issue Number: close #10110

Problem Summary:
See #10110

What is changed and how it works?

Fix incorrect conversion of column to nullable in Expand operator

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix incorrect conversion of column to nullable in Expand operator

gengliqi added 3 commits April 17, 2025 10:31
@gengliqi @ti-chi-bot
fix
c877420 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@gengliqi @ti-chi-bot
add integration tests
0fec068 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@gengliqi @ti-chi-bot
update tests
7541266 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-9.0-beta.1 labels Apr 17, 2025
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 17, 2025
Merged
12 tasks
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 17, 2025

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign windtalker for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gengliqi gengliqi closed this Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@gengliqi gengliqi

Labels

do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-9.0-beta.1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ti-chi-bot @gengliqi