Skip to content

Fix stale read can not eliminate the learner read on TiFlash#10099

Merged
ti-chi-bot[bot] merged 2 commits intomasterfrom
dependabot/submodules/contrib/tiflash-proxy-54aa039
Apr 16, 2025
Merged

Fix stale read can not eliminate the learner read on TiFlash#10099
ti-chi-bot[bot] merged 2 commits intomasterfrom
dependabot/submodules/contrib/tiflash-proxy-54aa039

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 14, 2025

Issue Number: ref #4982, close #10046

Bumps contrib/tiflash-proxy from 1157849 to 54aa039.

The leader_safe_ts, self_safe_ts are always 0 in the TiFlash side, making TiFlash can not eliminate the learner read on region without any updates. For detailed reasons why safe_ts failed to be updated, checkout the description on pingcap/tidb-engine-ext#429.

To obtain the fixed PR in proxy: pingcap/tidb-engine-ext#429


Commits
  • 54aa039 Merge tikv master near 9.0-beta.1(e5a3075936ddf05461c8e1a1398b513badf3f876) (...
  • 9a6839a Fix safe ts not updated (#429)
  • See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Release note

Fix the issue that `SELECT ... AS OF TIMESTAMP` can not eliminate the learner read on TiFlash as expected

@dependabot dependabot bot added dependencies Pull requests that update a dependency file submodules Pull requests that update submodules code labels Apr 14, 2025
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 14, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 14, 2025

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Apr 14, 2025
Bumps [contrib/tiflash-proxy](https://github.com/pingcap/tidb-engine-ext) from `1157849` to `54aa039`.
- [Commits](pingcap/tidb-engine-ext@1157849...54aa039)

---
updated-dependencies:
- dependency-name: contrib/tiflash-proxy
  dependency-version: 54aa039ba3e9ca9fffe3cf6c344f2822b405b3e4
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/submodules/contrib/tiflash-proxy-54aa039 branch from 56c83cc to 4b64a4e Compare April 15, 2025 02:02
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-linked-issue do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 16, 2025
@CalvinNeo
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. do-not-merge/needs-triage-completed and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Apr 16, 2025
@JaySon-Huang JaySon-Huang changed the title Bump contrib/tiflash-proxy from 1157849 to 54aa039 Fix stale read can not eliminate the learner read on TiFlash Apr 16, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CalvinNeo, JaySon-Huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [CalvinNeo,JaySon-Huang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 16, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 16, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-04-16 01:51:00.97775256 +0000 UTC m=+2825954.661988655: ☑️ agreed by CalvinNeo.
  • 2025-04-16 01:58:38.829568272 +0000 UTC m=+2826412.513804366: ☑️ agreed by JaySon-Huang.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Apr 16, 2025
@ti-chi-bot ti-chi-bot bot merged commit 260be7d into master Apr 16, 2025
5 checks passed
@ti-chi-bot ti-chi-bot bot deleted the dependabot/submodules/contrib/tiflash-proxy-54aa039 branch April 16, 2025 02:57
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Apr 24, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: failed to apply #10099 on top of branch "release-8.1":

[failed to git add conflicting files: exit status 128, failed to git commit: exit status 128]

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: failed to apply #10099 on top of branch "release-8.5":

[failed to git add conflicting files: exit status 128, failed to git commit: exit status 128]

ti-chi-bot bot pushed a commit that referenced this pull request Apr 24, 2025
…#10132)

ref #4982, close #10046

Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Apr 25, 2025
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. and removed needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Apr 25, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: failed to apply #10099 on top of branch "release-8.5":

[failed to git add conflicting files: exit status 128, failed to git commit: exit status 128]

@pingcap pingcap deleted a comment from ti-chi-bot Apr 25, 2025
@pingcap pingcap deleted a comment from ti-chi-bot Apr 25, 2025
ti-chi-bot bot pushed a commit that referenced this pull request Apr 25, 2025
…#10131)

ref #4982, close #10046

Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved dependencies Pull requests that update a dependency file lgtm needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. submodules Pull requests that update submodules code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable stale read can not eliminate the learner read on TiFlash at all

3 participants