Merged
Conversation
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
Lloyd-Pottiger
approved these changes
Mar 14, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Lloyd-Pottiger, xzhangxian1008 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
[LGTM Timeline notifier]Timeline:
|
Co-authored-by: JaySon <tshent@qq.com>
Co-authored-by: JaySon <tshent@qq.com>
gengliqi
reviewed
Mar 14, 2025
33cb5b4 to
8f1386d
Compare
windtalker
added a commit
to windtalker/tiflash
that referenced
this pull request
Mar 18, 2025
close pingcap#9999 Fix sort spill crash in some corner cases. Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn> Co-authored-by: JaySon <tshent@qq.com>
Member
|
In response to a cherrypick label: new pull request created to branch |
Member
|
In response to a cherrypick label: new pull request created to branch |
JaySon-Huang
added a commit
to ti-chi-bot/tiflash
that referenced
this pull request
Mar 31, 2025
close pingcap#9999 Fix sort spill crash in some corner cases. Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn> Co-authored-by: xufei <xufei@pingcap.com> Co-authored-by: xufei <xufeixw@mail.ustc.edu.cn> Co-authored-by: JaySon <tshent@qq.com>
yongman
pushed a commit
to yongman/tiflash
that referenced
this pull request
Jun 18, 2025
close pingcap#9999 Fix sort spill crash in some corner cases. Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn> Co-authored-by: xufei <xufei@pingcap.com> Co-authored-by: xufei <xufeixw@mail.ustc.edu.cn> Co-authored-by: JaySon <tshent@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #9999
Problem Summary:
What is changed and how it works?
The root cause is described in #9999, this pr fix the error and add some check in sort operator to avoid potential undefined fail when the input block of sort is not well generated.
Check List
Tests
Side effects
Documentation
Release note