Skip to content

Fix spill crash (#10004)#10014

Merged
ti-chi-bot[bot] merged 6 commits intopingcap:release-9.0-beta.1from
ti-chi-bot:cherry-pick-10004-to-release-9.0-beta.1
Mar 18, 2025
Merged

Fix spill crash (#10004)#10014
ti-chi-bot[bot] merged 6 commits intopingcap:release-9.0-beta.1from
ti-chi-bot:cherry-pick-10004-to-release-9.0-beta.1

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #10004

What problem does this PR solve?

Issue Number: close #9999

Problem Summary:

What is changed and how it works?

The root cause is described in #9999, this pr fix the error and add some check in sort operator to avoid potential undefined fail when the input block of sort is not well generated.

Fix sort spill crash in some corner cases.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix sort spill crash in some corner cases

windtalker and others added 6 commits March 18, 2025 03:37
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
Co-authored-by: JaySon <tshent@qq.com>
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-9.0-beta.1 labels Mar 18, 2025
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 18, 2025
12 tasks
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 18, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, xzhangxian1008

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 18, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 18, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-18 05:16:36.764753361 +0000 UTC m=+332690.448989454: ☑️ agreed by windtalker.
  • 2025-03-18 05:19:25.014524161 +0000 UTC m=+332858.698760242: ☑️ agreed by xzhangxian1008.

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Mar 18, 2025
@ti-chi-bot ti-chi-bot bot merged commit b71aa7c into pingcap:release-9.0-beta.1 Mar 18, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-9.0-beta.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants