-
Notifications
You must be signed in to change notification settings - Fork 409
Labels
type/code-quality-improvementPR that can improve the code qualityPR that can improve the code qualitytype/enhancementThe issue or PR belongs to an enhancement.The issue or PR belongs to an enhancement.
Description
Enhancement
The codes under "dbms/src/Storages/Transaction" are some codes we adapt TiFlash with TiDB. After years of development, it become kind of crowded and confusing.
Suggest breakdown "dbms/src/Storages/Transaction” into these modules:
- Some global context for TiFlash management
- Basic structure from TiDB (TableInfo/DatabaseInfo, etc)
- Syncing schema with TiDB
- Decoding data from row to column (Block)
- Raft layer
- Region info
- Handling admin command
- Handling write command
- Handling apply snapshot/ingest sst
- Handling learner read
- Suggest creating a
dbms/src/TiDBas the module for basic components from TiDB. And- Rename TMTContext to TiFlashContext
- Move TableInfo/DBInfo, etc from TiDB.h to
dbms/src/TiDB - Move TiFlashContext/ManagedStorages to the
dbms/src/TiDBmodule - Add a
dbms/src/TiDB/Codecand move the logic of decoding data from row to column there - Add a
dbms/src/TiDB/Schemaand move schema syncing logic there
- Rename
dbms/src/Transactiontodbms/src/KVStore. And maybe we should further break down the codes for different Raft processes under this module.- Rename
dbms/src/Transactiontodbms/src/KVStoreRefactor kvstore #8073 - Break down
KVStore. Refactor kvstore #8073
- Rename
Reactions are currently unavailable
Metadata
Metadata
Labels
type/code-quality-improvementPR that can improve the code qualityPR that can improve the code qualitytype/enhancementThe issue or PR belongs to an enhancement.The issue or PR belongs to an enhancement.