Merged
Conversation
JaySon-Huang
reviewed
Sep 8, 2023
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
a832033 to
795a5f7
Compare
JaySon-Huang
approved these changes
Sep 11, 2023
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Contributor
|
/run-all-tests |
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Member
Author
|
/run-all-tests |
Member
Author
|
/run-all-tests |
Member
Author
|
/run-all-tests |
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
flowbehappy
approved these changes
Sep 12, 2023
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flowbehappy, JaySon-Huang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
[LGTM Timeline notifier]Timeline:
|
Member
Author
|
/hold wait for learner read pr |
Member
Author
|
/unhold no more wait |
Member
Author
|
/unhold |
Member
Author
|
/run-all-tests |
Member
Author
|
/run-all-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #4646
Problem Summary:
The Transaction folder is renamed to KVStore, since it is originally a KVStore with a percolator executor to decode row data into column data built on raft kv.
The new KVStore folder will be made into a new
kvstorelibrary which will be linked todbms.The following files will be moved to TiDB:
The KVStore folder includes:
Storages/KVStore/Decodeis a bridge between KVStore and DeltaMerge. It is about:TiDBand decode the value in row format kvs.Storages/KVStore/FFIis FFI utils and interfaces with TiFlash Proxy.Storages/KVStore/MultiRaftcontains all modules that implements a raft kv. Including region, region manager, region range index.Storages/KVStore/UtilsStorages/KVStore/TiKVHelperscontains some util functions about definitions in TiKV which can be extract as common util function, such as key format for percolator/keyspace, and pd client. The key format part is about how to parse TiKVKey, and uses some information in TiKVValue to perform percolator 2pc commit. Note some TiKV key utils are related to schema or range of tables, we will put them inStorages/KVStore/Decode.Storages/KVStore/Readcontains all about learner read with strong consistency, inclduing mvcc and region lock info and read index. It does not include read from data KVStore and ingest into DeltaMerge, which is inStorages/KVStore/Decode.The whole classification is not accurate, since we still rely on some decoded data such as DecodedTiKVKey in MultiRaft.
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note