Enhance some debug utils#8225
Conversation
Co-authored-by: JaySon <tshent@qq.com>
…tics into rate-limit-parallel-prehandle
Co-authored-by: JaySon <tshent@qq.com>
Co-authored-by: JaySon <tshent@qq.com>
Co-authored-by: JaySon <tshent@qq.com>
Co-authored-by: JaySon <tshent@qq.com>
Co-authored-by: JaySon <tshent@qq.com>
…tics into rate-limit-parallel-prehandle
|
/run-all-tests |
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
|
/run-all-tests |
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
|
/run-all-tests |
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
|
/run-all-tests |
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
| static inline void validate( | ||
| KVStore & kvs, | ||
| std::unique_ptr<MockRaftStoreProxy> & proxy_instance, | ||
| UInt64 region_id, | ||
| MockSSTGenerator & cf_data, | ||
| ColumnFamilyType cf, | ||
| int sst_size, | ||
| int key_count) |
There was a problem hiding this comment.
| static inline void validate( | |
| KVStore & kvs, | |
| std::unique_ptr<MockRaftStoreProxy> & proxy_instance, | |
| UInt64 region_id, | |
| MockSSTGenerator & cf_data, | |
| ColumnFamilyType cf, | |
| int sst_size, | |
| int key_count) | |
| static inline void validate( | |
| KVStore & kvs, | |
| std::unique_ptr<MockRaftStoreProxy> & proxy_instance, | |
| UInt64 region_id, | |
| MockSSTGenerator & cf_data, | |
| ColumnFamilyType cf, | |
| int sst_size, | |
| int key_count) |
Can you add some comments to explain what kind of data/fields this function validate?
| { | ||
| RegionException::UnavailableRegions fail_region_ids; | ||
| RegionException::RegionReadStatus fail_status = RegionException::RegionReadStatus::OK; | ||
| std::string fail_extra_msg; |
There was a problem hiding this comment.
I think "err_msg" or "error_msg" is more native speaking in English
There was a problem hiding this comment.
The previous variables are all begin with fail
| log, | ||
| "Check after snapshot acquired from storage, region_id={} version={} handle_range={} status={}", | ||
| "Check after snapshot acquired from storage, region_id={} version={} handle_range={} status={} " | ||
| "fail_msg={}", |
There was a problem hiding this comment.
| "fail_msg={}", | |
| "err_msg={}", |
There was a problem hiding this comment.
This message is extra, the final error msg is construncted in UnavailableRegions
Co-authored-by: JaySon <tshent@qq.com>
Co-authored-by: JaySon <tshent@qq.com>
|
/run-all-tests |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JaySon-Huang, JinheLin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
@CalvinNeo: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests
If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #4646
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note