executor,planner: Improve SET PASSWORD#8426
Merged
zz-jason merged 5 commits intopingcap:masterfrom Nov 26, 2018
morgo:set-password
Merged
executor,planner: Improve SET PASSWORD#8426zz-jason merged 5 commits intopingcap:masterfrom morgo:set-password
zz-jason merged 5 commits intopingcap:masterfrom
morgo:set-password
Conversation
MySQL compatible behavior
Contributor
Author
|
/run-all-tests |
Contributor
Author
|
/run-unit-test |
Contributor
Author
|
PTAL @tiancaiamao |
Contributor
|
LGTM |
jackysp
reviewed
Nov 26, 2018
| s.User = vars.User | ||
| if s.User == nil { | ||
| if e.ctx.GetSessionVars().User == nil { | ||
| return errors.New("Session error is empty") |
Contributor
There was a problem hiding this comment.
Why the error is "Session error is empty"? Although it is not related to this PR.
Contributor
Author
There was a problem hiding this comment.
When the test-suite runs, it doesn't always have a session. This error is pre-existing, I just moved it around.
tiancaiamao
added a commit
to tiancaiamao/tidb
that referenced
this pull request
Nov 28, 2019
sre-bot
pushed a commit
that referenced
this pull request
Dec 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fixes #7522
What is changed and how it works?
This PR will conflict with #8417 as they both add the same error to the executor. I will see which one is merged first and then fix the code :-)
There remains an issue common to all GRANT/SET password/CREATE user commands in that they do not invalidate the privilege cache (as MySQL versions do). See #8427
Check List
Tests
Code changes
Side effects
Related changes
This change is