executor: improve SHOW commands compatibility#8417
Merged
zz-jason merged 6 commits intopingcap:masterfrom Nov 26, 2018
morgo:show-table-status
Merged
executor: improve SHOW commands compatibility#8417zz-jason merged 6 commits intopingcap:masterfrom morgo:show-table-status
zz-jason merged 6 commits intopingcap:masterfrom
morgo:show-table-status
Conversation
Improved mysql compatibility (partition info) and grant semantics.
Contributor
Author
|
/run-all-tests |
Contributor
|
LGTM |
zz-jason
reviewed
Nov 26, 2018
Fixed nag from goword (comment removed, not required)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Improves MySQL compatibility of SHOW commands, plus an enhancement to derive info from infoschema to reduce duplication.
What is changed and how it works?
Lots of small compatibility bugs:
SHOW ENGINESandSHOW TABLE STATUSto infoschema (saves duplication)SHOW TABLE STATUScolumnCheck List
Tests
Code changes
Side effects
The added privilege checks may break incorrect apps.
Related changes
tidb-ansiblerepositoryThis change is