Skip to content

parser, planner: fix embedded setOprStmt will be seen as SetOprSelectList item and lost its orderBy and Limit#49421

Merged
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
AilinKid:fix_setOprStmt_limit_and_order_limit
Dec 15, 2023
Merged

parser, planner: fix embedded setOprStmt will be seen as SetOprSelectList item and lost its orderBy and Limit#49421
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
AilinKid:fix_setOprStmt_limit_and_order_limit

Conversation

@AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Dec 13, 2023 •
edited by bb7133
Loading

What problem does this PR solve?

Issue Number: close #49377

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

parser, planner: fix embedded setOprStmt will be seen as SetOprSelectList item and lost its orderBy and Limit

@AilinKid
fix embedded setOprStmt will be seen as SetOprSelectList and lost its…
3b40748 
… orderBy and Limit

Signed-off-by: AilinKid <314806019@qq.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 13, 2023
@tiprow
Copy link

tiprow bot commented Dec 13, 2023

Hi @AilinKid. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AilinKid
make parser
c4945d4 
Signed-off-by: AilinKid <314806019@qq.com>
@AilinKid
.
3ecc8bf 
Signed-off-by: AilinKid <314806019@qq.com>
@codecov
Copy link

codecov bot commented Dec 13, 2023 •
edited
Loading

Codecov Report

Merging #49421 (11912ec) into master (3379450) will increase coverage by 0.6340%.
Report is 27 commits behind head on master.
The diff coverage is 25.0000%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #49421        +/-   ##
================================================
+ Coverage   71.0549%   71.6889%   +0.6340%     
================================================
  Files          1368       1417        +49     
  Lines        401271     422973     +21702     
================================================
+ Hits         285123     303225     +18102     
- Misses        96324     100836      +4512     
+ Partials      19824      18912       -912
Flag Coverage Δ
integration 44.0145% <25.0000%> (?)
unit 71.0550% <ø> (+0.0001%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 47.5164% <ø> (-5.3685%) ⬇️

bb7133
bb7133 reviewed Dec 14, 2023
View reviewed changes
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 14, 2023
@AilinKid
.
11912ec 
Signed-off-by: AilinKid <314806019@qq.com>
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 14, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 14, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-14 07:10:53.550167079 +0000 UTC m=+512944.587394008: ☑️ agreed by qw4990.
  • 2023-12-14 08:01:05.696089301 +0000 UTC m=+515956.733316213: ☑️ agreed by tangenta.

fixdb
fixdb approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@fixdb fixdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still some test failures.

@bb7133
Copy link
Member

bb7133 commented Dec 15, 2023

/rebuild

@bb7133 bb7133 closed this Dec 15, 2023
@bb7133 bb7133 reopened this Dec 15, 2023
@bb7133
Copy link
Member

bb7133 commented Dec 15, 2023

/retest

bb7133
bb7133 approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@easonn7
Copy link

easonn7 commented Dec 15, 2023

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, easonn7, fixdb, qw4990, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 15, 2023
@ti-chi-bot ti-chi-bot bot merged commit 4238341 into pingcap:master Dec 15, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 15, 2023
Merged
13 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 15, 2023

In response to a cherrypick label: new pull request created to branch release-7.5: #49499.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 15, 2023
@AilinKid @ti-chi-bot
This is an automated cherry-pick of pingcap#49421
d041d20 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 15, 2023

In response to a cherrypick label: new pull request created to branch release-5.4: #49500.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 15, 2023
Closed
13 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 15, 2023
@AilinKid @ti-chi-bot
This is an automated cherry-pick of pingcap#49421
c538194 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 15, 2023

In response to a cherrypick label: new pull request created to branch release-6.1: #49501.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 15, 2023
Closed
13 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 15, 2023
@AilinKid @ti-chi-bot
This is an automated cherry-pick of pingcap#49421
d34ef7c 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 15, 2023
Merged
13 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 15, 2023

In response to a cherrypick label: new pull request created to branch release-6.5: #49502.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 15, 2023
@AilinKid @ti-chi-bot
This is an automated cherry-pick of pingcap#49421
c7f85b3 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 15, 2023
Closed
13 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 15, 2023

In response to a cherrypick label: new pull request created to branch release-7.1: #49503.

AilinKid added a commit to ti-chi-bot/tidb that referenced this pull request Dec 19, 2023
@AilinKid
This is an automated cherry-pick of pingcap#49421
9e7785a 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
AilinKid added a commit to AilinKid/tidb that referenced this pull request Dec 19, 2023
@AilinKid
parser, planner: fix embedded setOprStmt will be seen as SetOprSelect…
ba2e5a6 
…List item and lost its orderBy and Limit (pingcap#49421)

close pingcap#49377
ti-chi-bot bot pushed a commit that referenced this pull request Dec 22, 2023
@ti-chi-bot
parser, planner: fix embedded setOprStmt will be seen as SetOprSelect…
0882912 
…List item and lost its orderBy and Limit (#49421) (#49502)

close #49377
AilinKid added a commit to ti-chi-bot/tidb that referenced this pull request Feb 19, 2024
@AilinKid
This is an automated cherry-pick of pingcap#49421
aecfc59 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot bot pushed a commit that referenced this pull request Feb 20, 2024
@ti-chi-bot
parser, planner: fix embedded setOprStmt will be seen as SetOprSelect…
a91305e 
…List item and lost its orderBy and Limit (#49421) (#49499)

close #49377
budney pushed a commit to budney/tidb that referenced this pull request May 18, 2025
@AilinKid
parser, planner: fix embedded setOprStmt will be seen as SetOprSelect…
4c47c3b 
…List item and lost its orderBy and Limit (pingcap#49421)

close pingcap#49377
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bb7133 bb7133 bb7133 approved these changes

@fixdb fixdb fixdb approved these changes

@qw4990 qw4990 qw4990 approved these changes

@tangenta tangenta tangenta approved these changes

Assignees

No one assigned

Labels

approved lgtm needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Nested union with LIMIT handles incorrectly

7 participants

@AilinKid @bb7133 @easonn7 @ti-chi-bot @fixdb @qw4990 @tangenta