Skip to content

parser, planner: fix embedded setOprStmt will be seen as SetOprSelectList item and lost its orderBy and Limit (#49421)#49499

Merged
ti-chi-bot[bot] merged 3 commits intopingcap:release-7.5from
ti-chi-bot:cherry-pick-49421-to-release-7.5
Feb 20, 2024
Merged

parser, planner: fix embedded setOprStmt will be seen as SetOprSelectList item and lost its orderBy and Limit (#49421)#49499
ti-chi-bot[bot] merged 3 commits intopingcap:release-7.5from
ti-chi-bot:cherry-pick-49421-to-release-7.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Dec 15, 2023

This is an automated cherry-pick of #49421

What problem does this PR solve?

Issue Number: close #49377

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

parser, planner: fix embedded setOprStmt will be seen as SetOprSelectList item and lost its orderBy and Limit

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Dec 15, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 15, 2023
Merged
13 tasks
@Defined2014 Defined2014 mentioned this pull request Dec 29, 2023
Merged
13 tasks
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 3, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 3, 2024

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 6, 2024
@AilinKid
This is an automated cherry-pick of pingcap#49421
aecfc59 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@AilinKid
resolve conflicts
f860cca 
Signed-off-by: AilinKid <314806019@qq.com>
@AilinKid
,.
9265b22 
Signed-off-by: AilinKid <314806019@qq.com>
@AilinKid AilinKid force-pushed the cherry-pick-49421-to-release-7.5 branch from e9c7933 to 9265b22 Compare February 19, 2024 10:26
@codecov
Copy link

codecov bot commented Feb 19, 2024 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release-7.5@3b7f150). Click here to learn what that means.
The diff coverage is 100.0000%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-7.5     #49499   +/-   ##
================================================
  Coverage               ?   73.0949%           
================================================
  Files                  ?       1404           
  Lines                  ?     415171           
  Branches               ?          0           
================================================
  Hits                   ?     303469           
  Misses                 ?      92326           
  Partials               ?      19376
Flag Coverage Δ
unit 73.0949% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.4602% <0.0000%> (?)

@AilinKid
Copy link
Contributor

AilinKid commented Feb 19, 2024

/build

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 19, 2024
@AilinKid AilinKid closed this Feb 19, 2024
@AilinKid AilinKid reopened this Feb 19, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 20, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-19 11:47:53.57151057 +0000 UTC m=+271362.319133680: ☑️ agreed by AilinKid.
  • 2024-02-20 03:39:19.64543473 +0000 UTC m=+328448.393057838: ☑️ agreed by Defined2014.

@AilinKid
Copy link
Contributor

AilinKid commented Feb 20, 2024

/approve

bb7133
bb7133 approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@easonn7
Copy link

easonn7 commented Feb 20, 2024

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, bb7133, Defined2014, easonn7, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 20, 2024
@Defined2014 Defined2014 removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 20, 2024
@Defined2014
Copy link
Contributor

Defined2014 commented Feb 20, 2024

/retest

1 similar comment
@Defined2014
Copy link
Contributor

Defined2014 commented Feb 20, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit a91305e into pingcap:release-7.5 Feb 20, 2024
@Defined2014 Defined2014 deleted the cherry-pick-49421-to-release-7.5 branch February 20, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bb7133 bb7133 bb7133 approved these changes

@AilinKid AilinKid AilinKid approved these changes

@Defined2014 Defined2014 Defined2014 approved these changes

@tangenta tangenta tangenta approved these changes

Assignees

@AilinKid AilinKid

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ti-chi-bot @AilinKid @easonn7 @Defined2014 @bb7133 @tangenta