Skip to content

ddl: Exchange part schema load fix#46126

Merged
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
mjonss:exchange-part-schema-load-fix
Aug 17, 2023
Merged

ddl: Exchange part schema load fix#46126
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
mjonss:exchange-part-schema-load-fix

Conversation

@mjonss
Copy link
Contributor

@mjonss mjonss commented Aug 15, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #46125 close #45791

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Manual test:
Build this PR and use it for starting a cluster tiup playground --db.binpath ./bin/tidb-server
and then run tiflash test sh run-test.sh fullstack-test2/ddl/alter_exchange_partition.test which no longer fails
Also check the tidb.log that there are no failures loading new schema diffs, so no full schema reloads are needed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

(Unless 7.4 get released without this fix).

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-triage-completed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 15, 2023
@tiprow
Copy link

tiprow bot commented Aug 15, 2023

Hi @mjonss. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 15, 2023
@codecov
Copy link

codecov bot commented Aug 15, 2023 •
edited
Loading

Codecov Report

Merging #46126 (8af8ff1) into master (3846e80) will decrease coverage by 2.0921%.
Report is 15 commits behind head on master.
The diff coverage is 75.7575%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #46126        +/-   ##
================================================
- Coverage   74.7667%   72.6746%   -2.0921%     
================================================
  Files          1292       1304        +12     
  Lines        398141     400460      +2319     
================================================
- Hits         297677     291033      -6644     
- Misses        81100      90938      +9838     
+ Partials      19364      18489       -875
Flag Coverage Δ
integration 25.5845% <1.5151%> (-20.6784%) ⬇️
unit 73.3550% <75.7575%> (+0.0028%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0656% <ø> (ø)
br 47.7384% <ø> (-16.7741%) ⬇️

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 16, 2023
@mjonss mjonss mentioned this pull request Aug 16, 2023
Open
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 16, 2023
@mjonss
Copy link
Contributor Author

mjonss commented Aug 16, 2023

/test check-issue-triage-complete

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 16, 2023

@mjonss: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build
  • /test canary-scan-security
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test pingcap/tidb/canary_ghpr_unit_test
  • /test pull-br-integration-test
  • /test pull-common-test
  • /test pull-e2e-test
  • /test pull-integration-common-test
  • /test pull-integration-copr-test
  • /test pull-integration-ddl-test
  • /test pull-integration-jdbc-test
  • /test pull-integration-mysql-test
  • /test pull-mysql-connector-test
  • /test pull-sqllogic-test
  • /test pull-tiflash-test
  • /test unit-test

The following commands are available to trigger optional jobs:

  • /test pull-notify-when-compatibility-sections-changed

Use /test all to run the following jobs that were automatically triggered:

  • pingcap/tidb/ghpr_build
  • pingcap/tidb/ghpr_check
  • pingcap/tidb/ghpr_check2
  • pingcap/tidb/ghpr_mysql_test
  • pingcap/tidb/ghpr_unit_test
Details

In response to this:

/test check-issue-triage-complete

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiprow
Copy link

tiprow bot commented Aug 16, 2023

@mjonss: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test check-issue-triage-complete

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. and removed do-not-merge/needs-triage-completed labels Aug 17, 2023
bb7133
bb7133 approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

�LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, tiancaiamao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 17, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 17, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-17 01:42:31.493610442 +0000 UTC m=+768116.042626414: ☑️ agreed by tiancaiamao.
  • 2023-08-17 10:32:06.908016391 +0000 UTC m=+799891.457032377: ☑️ agreed by bb7133.

@bb7133
Copy link
Member

bb7133 commented Aug 17, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 17, 2023

@bb7133: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 48e2297 into pingcap:master Aug 17, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 17, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 17, 2023

In response to a cherrypick label: new pull request created to branch release-6.5: #46191.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Aug 17, 2023
@mjonss @ti-chi-bot
This is an automated cherry-pick of pingcap#46126
f574f79 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 17, 2023

In response to a cherrypick label: new pull request created to branch release-7.1: #46193.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 17, 2023
Closed
12 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Aug 17, 2023
@mjonss @ti-chi-bot
This is an automated cherry-pick of pingcap#46126
be821d2 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@mjonss mjonss deleted the exchange-part-schema-load-fix branch August 17, 2023 11:30
mjonss added a commit to ti-chi-bot/tidb that referenced this pull request Aug 17, 2023
@mjonss
Revert "This is an automated cherry-pick of pingcap#46126"
bccacfc 
This reverts commit f574f79.
mjonss added a commit to ti-chi-bot/tidb that referenced this pull request Aug 17, 2023
@mjonss
ddl: Exchange part schema load fix (pingcap#46126)
8ad6dc7 
close pingcap#45791, ref pingcap#46125
@mjonss mjonss mentioned this pull request Aug 17, 2023
Closed
ti-chi-bot bot pushed a commit that referenced this pull request Sep 16, 2023
@ti-chi-bot
ddl: Exchange part schema load fix (#46126) (#46191)
774c4e7 
close #45791, ref #46125
mjonss added a commit to ti-chi-bot/tidb that referenced this pull request Oct 5, 2023
@mjonss
Including changes from pingcap#46126
9bc71de
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bb7133 bb7133 bb7133 approved these changes

@tiancaiamao tiancaiamao tiancaiamao approved these changes

Assignees

No one assigned

Labels

approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

exchange partition will fail when table has placement policy and then insert will fail forever

4 participants

@mjonss @bb7133 @ti-chi-bot @tiancaiamao