Skip to content

ddl: Exchange part schema load fix (#46126)#46191

Merged
ti-chi-bot[bot] merged 17 commits intopingcap:release-6.5from
ti-chi-bot:cherry-pick-46126-to-release-6.5
Sep 16, 2023
Merged

ddl: Exchange part schema load fix (#46126)#46191
ti-chi-bot[bot] merged 17 commits intopingcap:release-6.5from
ti-chi-bot:cherry-pick-46126-to-release-6.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Aug 17, 2023

This is an automated cherry-pick of #46126

What problem does this PR solve?

Issue Number: ref #46125 close #45791

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Manual test:
Build this PR and use it for starting a cluster tiup playground --db.binpath ./bin/tidb-server
and then run tiflash test sh run-test.sh fullstack-test2/ddl/alter_exchange_partition.test which no longer fails
Also check the tidb.log that there are no failures loading new schema diffs, so no full schema reloads are needed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

(Unless 7.4 get released without this fix).

mjonss added 2 commits August 10, 2023 14:31
@mjonss @ti-chi-bot
This is an automated cherry-pick of pingcap#45877
4d5ea32 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@mjonss @ti-chi-bot
This is an automated cherry-pick of pingcap#46126
f574f79 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Aug 17, 2023
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels Aug 17, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 17, 2023
Merged
12 tasks
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 17, 2023
@mjonss
Copy link
Contributor

mjonss commented Aug 17, 2023

/retest

@mjonss
Copy link
Contributor

mjonss commented Aug 18, 2023

/retest

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 18, 2023
@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Aug 21, 2023
@ti-chi-bot ti-chi-bot closed this Aug 21, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Sep 11, 2023
@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented Sep 15, 2023

/reopen

@ti-chi-bot ti-chi-bot bot reopened this Sep 15, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 15, 2023

@JaySon-Huang: Reopened this PR.

Details

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented Sep 15, 2023

Reopen it because #45980 is backport to release-6.5 and it make TiFlash hangs after executing exchange partition

@JaySon-Huang JaySon-Huang mentioned this pull request Sep 15, 2023
Merged
12 tasks
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 15, 2023
@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented Sep 15, 2023

/test unit-test

@tiprow
Copy link

tiprow bot commented Sep 15, 2023

@JaySon-Huang: No presubmit jobs available for pingcap/tidb@release-6.5

Details

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 15, 2023
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 15, 2023
@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented Sep 15, 2023

/retest

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@ec0ffe8). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-6.5     #46191   +/-   ##
================================================
  Coverage               ?   73.6675%           
================================================
  Files                  ?       1084           
  Lines                  ?     348304           
  Branches               ?          0           
================================================
  Hits                   ?     256587           
  Misses                 ?      75247           
  Partials               ?      16470

bb7133
bb7133 approved these changes Sep 16, 2023
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, mjonss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 16, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 16, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-15 11:31:18.391933996 +0000 UTC m=+257844.359522046: ☑️ agreed by mjonss.
  • 2023-09-16 15:26:33.316449348 +0000 UTC m=+358359.284037398: ☑️ agreed by bb7133.

@bb7133
Copy link
Member

bb7133 commented Sep 16, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 16, 2023

@bb7133: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 774c4e7 into pingcap:release-6.5 Sep 16, 2023
@ti-chi-bot ti-chi-bot deleted the cherry-pick-46126-to-release-6.5 branch April 15, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bb7133 bb7133 bb7133 approved these changes

@mjonss mjonss mjonss approved these changes

Assignees

@mjonss mjonss

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ti-chi-bot @mjonss @JaySon-Huang @bb7133