Skip to content

executor: optimize load data assignment expressions#46082

Merged
ti-chi-bot[bot] merged 4 commits intopingcap:release-6.5from
gengliqi:load-data-assign-expr
Aug 15, 2023
Merged

executor: optimize load data assignment expressions#46082
ti-chi-bot[bot] merged 4 commits intopingcap:release-6.5from
gengliqi:load-data-assign-expr

Conversation

@gengliqi
Copy link
Contributor

@gengliqi gengliqi commented Aug 14, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #46081

Problem Summary:
See #46081.

What is changed and how it works?

Calling rewriteAstExpr only once for each expression. Then evaluating these expressions for each row.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Optimize load data assignment expressions

@gengliqi
optimize load data assign expr
1d7829b 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 14, 2023
@gengliqi
update
0ebd48a 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@codecov
Copy link

codecov bot commented Aug 14, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@361fe40). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-6.5     #46082   +/-   ##
================================================
  Coverage               ?   73.6677%           
================================================
  Files                  ?       1083           
  Lines                  ?     347543           
  Branches               ?          0           
================================================
  Hits                   ?     256027           
  Misses                 ?      75070           
  Partials               ?      16446

D3Hunter
D3Hunter approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@D3Hunter D3Hunter left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have a test on cpu perf before/after this pr?

rest lgtm

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 15, 2023
windtalker
windtalker reviewed Aug 15, 2023
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And should add some tests

@gengliqi
add test for nullif function
7fdf9aa 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 15, 2023
@gengliqi
address comments
850c830 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@gengliqi gengliqi changed the title load data: optimize assignment expressions executor: optimize load data assignment expressions Aug 15, 2023
@gengliqi gengliqi requested a review from windtalker August 15, 2023 08:37
windtalker
windtalker approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 15, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [D3Hunter,windtalker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 15, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 15, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-15 03:22:23.074150689 +0000 UTC m=+601307.623166661: ☑️ agreed by D3Hunter.
  • 2023-08-15 08:38:07.915748909 +0000 UTC m=+620252.464764881: ☑️ agreed by windtalker.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Aug 15, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 15, 2023
@ti-chi-bot ti-chi-bot bot merged commit 3144a46 into pingcap:release-6.5 Aug 15, 2023
@gengliqi
Copy link
Contributor Author

gengliqi commented Aug 15, 2023

/cherrypick release-6.5-20230425-v6.5.2

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 15, 2023

@gengliqi: new pull request created to branch release-6.5-20230425-v6.5.2: #46110.

Details

In response to this:

/cherrypick release-6.5-20230425-v6.5.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 15, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Aug 15, 2023
@ti-chi-bot
executor: optimize load data assignment expressions (#46082) (#46110)
ab110b5 
close #46081
@lance6716 lance6716 mentioned this pull request Aug 31, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@windtalker windtalker windtalker approved these changes

@D3Hunter D3Hunter D3Hunter approved these changes

Assignees

No one assigned

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gengliqi @ti-chi-bot @windtalker @D3Hunter