Skip to content

executor: optimize load data assignment expressions (#46082) | tidb-test=pr/2145#46110

Merged
ti-chi-bot[bot] merged 4 commits intopingcap:release-6.5-20230425-v6.5.2from
ti-chi-bot:cherry-pick-46082-to-release-6.5-20230425-v6.5.2
Aug 15, 2023
Merged

executor: optimize load data assignment expressions (#46082) | tidb-test=pr/2145#46110
ti-chi-bot[bot] merged 4 commits intopingcap:release-6.5-20230425-v6.5.2from
ti-chi-bot:cherry-pick-46082-to-release-6.5-20230425-v6.5.2

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Aug 15, 2023

This is an automated cherry-pick of #46082

What problem does this PR solve?

Issue Number: close #46081

Problem Summary:
See #46081.

What is changed and how it works?

Calling rewriteAstExpr only once for each expression. Then evaluating these expressions for each row.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Optimize load data assignment expressions

@gengliqi @ti-chi-bot
optimize load data assign expr
99ab147 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@gengliqi @ti-chi-bot
update
28d362f 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@gengliqi @ti-chi-bot
add test for nullif function
d70b609 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@gengliqi @ti-chi-bot
address comments
d0d1a03 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5-20230425-v6.5.2 labels Aug 15, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 15, 2023
Merged
12 tasks
windtalker
windtalker approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 15, 2023
@gengliqi
Copy link
Contributor

gengliqi commented Aug 15, 2023

/test mysql-test tidb-test=pr/2145

@tiprow
Copy link

tiprow bot commented Aug 15, 2023

@gengliqi: No presubmit jobs available for pingcap/tidb@release-6.5-20230425-v6.5.2

Details

In response to this:

/test mysql-test tidb-test=pr/2145

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 15, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SeaRise, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 15, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 15, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-15 09:11:40.096191719 +0000 UTC m=+622264.645207691: ☑️ agreed by windtalker.
  • 2023-08-15 09:30:58.181670015 +0000 UTC m=+623422.730686002: ☑️ agreed by SeaRise.

@windtalker windtalker changed the title executor: optimize load data assignment expressions (#46082) executor: optimize load data assignment expressions (#46082) | tidb-test=pr/2145 Aug 15, 2023
@gengliqi
Copy link
Contributor

gengliqi commented Aug 15, 2023

/retest

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5-20230425-v6.5.2@6e593be). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files 
@@                       Coverage Diff                        @@
##             release-6.5-20230425-v6.5.2     #46110   +/-   ##
================================================================
  Coverage                               ?   73.4033%           
================================================================
  Files                                  ?       1079           
  Lines                                  ?     345991           
  Branches                               ?          0           
================================================================
  Hits                                   ?     253969           
  Misses                                 ?      75593           
  Partials                               ?      16429

@ti-chi-bot ti-chi-bot bot merged commit ab110b5 into pingcap:release-6.5-20230425-v6.5.2 Aug 15, 2023
@ti-chi-bot ti-chi-bot deleted the cherry-pick-46082-to-release-6.5-20230425-v6.5.2 branch April 15, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@windtalker windtalker windtalker approved these changes

+1 more reviewer

@SeaRise SeaRise SeaRise approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@gengliqi gengliqi

Labels

approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5-20230425-v6.5.2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ti-chi-bot @gengliqi @windtalker @SeaRise