Skip to content

test: fix TestIfFunctionWithNull#44229

Merged
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
Defined2014:fix-44226
May 29, 2023
Merged

test: fix TestIfFunctionWithNull#44229
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
Defined2014:fix-44226

Conversation

@Defined2014
Copy link
Contributor

@Defined2014 Defined2014 commented May 29, 2023

What problem does this PR solve?

Issue Number: close #44226

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 29, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 29, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 29, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 29, 2023
@hawkingrei
Copy link
Member

hawkingrei commented May 29, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 29, 2023

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 3c78ed5

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 29, 2023
@ti-chi-bot ti-chi-bot bot merged commit 6888a1a into pingcap:master May 29, 2023
@hawkingrei
Copy link
Member

hawkingrei commented May 29, 2023

/cherrypick release-7.1

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 29, 2023

@hawkingrei: new pull request could not be created: failed to create pull request against pingcap/tidb#release-7.1 from head ti-chi-bot:cherry-pick-44229-to-release-7.1: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between pingcap:release-7.1 and ti-chi-bot:cherry-pick-44229-to-release-7.1"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

Details

In response to this:

/cherrypick release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Defined2014
Copy link
Contributor Author

Defined2014 commented May 29, 2023 •
edited
Loading

/cherrypick release-7.1

already cherry-picked by https://github.com/pingcap/tidb/pull/44062/files#diff-aa2aa66e187b1bf077b679e44433c5e83eeb35d1a903c4fdd6b250044b2f5968

@YangKeao YangKeao added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label May 29, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request May 29, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 29, 2023

In response to a cherrypick label: new pull request created to branch release-6.5: #44233.

@YangKeao YangKeao added needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. and removed needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels May 29, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request May 29, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 29, 2023

In response to a cherrypick label: new pull request created to branch release-5.2: #44234.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 29, 2023
@Defined2014 @ti-chi-bot
This is an automated cherry-pick of pingcap#44229
b42b4cb 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request May 29, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 29, 2023

In response to a cherrypick label: new pull request created to branch release-5.1: #44235.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 29, 2023
@Defined2014 @ti-chi-bot
This is an automated cherry-pick of pingcap#44229
e830f27 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 29, 2023

In response to a cherrypick label: new pull request created to branch release-5.4: #44236.

This was referenced May 29, 2023
Merged
Merged
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 29, 2023

In response to a cherrypick label: new pull request created to branch release-5.3: #44237.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 29, 2023

In response to a cherrypick label: new pull request could not be created: failed to create pull request against pingcap/tidb#release-7.1 from head ti-chi-bot:cherry-pick-44229-to-release-7.1: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between pingcap:release-7.1 and ti-chi-bot:cherry-pick-44229-to-release-7.1"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

@ti-chi-bot ti-chi-bot mentioned this pull request May 29, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 29, 2023

In response to a cherrypick label: new pull request created to branch release-6.1: #44238.

ti-chi-bot bot pushed a commit that referenced this pull request May 29, 2023
@ti-chi-bot
test: fix TestIfFunctionWithNull (#44229) (#44236)
9d945fb 
close #44226
ti-chi-bot bot pushed a commit that referenced this pull request May 29, 2023
@ti-chi-bot
test: fix TestIfFunctionWithNull (#44229) (#44233)
c2f31b5 
close #44226
ti-chi-bot bot pushed a commit that referenced this pull request May 29, 2023
@ti-chi-bot
test: fix TestIfFunctionWithNull (#44229) (#44238)
ac8669c 
close #44226
ti-chi-bot bot pushed a commit that referenced this pull request May 29, 2023
@ti-chi-bot
test: fix TestIfFunctionWithNull (#44229) (#44235)
b285908 
close #44226
ti-chi-bot bot pushed a commit that referenced this pull request May 29, 2023
@ti-chi-bot
test: fix TestIfFunctionWithNull (#44229) (#44234)
c96c765 
close #44226
ti-chi-bot bot pushed a commit that referenced this pull request May 29, 2023
@ti-chi-bot
test: fix TestIfFunctionWithNull (#44229) (#44237)
67f820e 
close #44226
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lance6716 lance6716 lance6716 approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

@xhebox xhebox Awaiting requested review from xhebox

Assignees

No one assigned

Labels

needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

unstable test TestIfFunctionWithNull

5 participants

@Defined2014 @hawkingrei @ti-chi-bot @lance6716 @YangKeao