Skip to content

test: fix TestIfFunctionWithNull (#44229)#44233

Merged
ti-chi-bot[bot] merged 1 commit intopingcap:release-6.5from
ti-chi-bot:cherry-pick-44229-to-release-6.5
May 29, 2023
Merged

test: fix TestIfFunctionWithNull (#44229)#44233
ti-chi-bot[bot] merged 1 commit intopingcap:release-6.5from
ti-chi-bot:cherry-pick-44229-to-release-6.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented May 29, 2023

This is an automated cherry-pick of #44229

What problem does this PR solve?

Issue Number: close #44226

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label May 29, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request May 29, 2023
Merged
12 tasks
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 29, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • YangKeao
  • hawkingrei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels May 29, 2023
@YangKeao YangKeao requested review from Defined2014 and wshwsh12 May 29, 2023 05:29
YangKeao
YangKeao approved these changes May 29, 2023
View reviewed changes
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 29, 2023
@YangKeao YangKeao mentioned this pull request May 29, 2023
Merged
4 tasks
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 29, 2023
@hawkingrei
Copy link
Member

hawkingrei commented May 29, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 29, 2023

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 0b30c38

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 29, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels May 29, 2023
@ti-chi-bot ti-chi-bot bot merged commit c2f31b5 into pingcap:release-6.5 May 29, 2023
@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Jun 14, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 14, 2023
@Defined2014 Defined2014 deleted the cherry-pick-44229-to-release-6.5 branch June 14, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@YangKeao YangKeao YangKeao approved these changes

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

@Defined2014 Defined2014 Awaiting requested review from Defined2014

Assignees

@Defined2014 Defined2014

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ti-chi-bot @hawkingrei @YangKeao @VelocityLight @Defined2014