Skip to content

log-backup: do not rewrite shortvalue iif the value is rollback record.#39596

Merged
ti-chi-bot merged 5 commits intopingcap:masterfrom
joccau:fix-rewrite-shortvalue
Dec 2, 2022
Merged

log-backup: do not rewrite shortvalue iif the value is rollback record.#39596
ti-chi-bot merged 5 commits intopingcap:masterfrom
joccau:fix-rewrite-shortvalue

Conversation

@joccau
Copy link
Contributor

@joccau joccau commented Dec 2, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #39575

Problem Summary:

  • Failed to unmarsher short-value into DbInfo because the meta-kv is rollback record.

What is changed and how it works?

  • Skip rewrite value if the meta-kv is rollback record.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

joccau added 4 commits December 2, 2022 12:35
debug
eb475a4 
Signed-off-by: joccau <zak.zhao@pingcap.com>
don't rewrite short-value if the value is rollback record
6406973 
Signed-off-by: joccau <zak.zhao@pingcap.com>
add more memeber in write cf valud
2ddf385 
Signed-off-by: joccau <zak.zhao@pingcap.com>
add test cases
8f61a6f 
Signed-off-by: joccau <zak.zhao@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 2, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • YuJuncen

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/needs-triage-completed labels Dec 2, 2022
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. and removed do-not-merge/needs-triage-completed labels Dec 2, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 2, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 2, 2022
@joccau
Copy link
Contributor Author

joccau commented Dec 2, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 2, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 8f61a6f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 2, 2022
@ti-chi-bot ti-chi-bot merged commit e89f341 into pingcap:master Dec 2, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 2, 2022

In response to a cherrypick label: new pull request created: #39599.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 2, 2022
Merged
12 tasks
@sre-bot
Copy link
Contributor

sre-bot commented Dec 2, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [1] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🔴 failed 1, success 39, total 40 25 min Existing failure
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 1, success 16, total 17 15 min Existing failure
idc-jenkins-ci-tidb/common-test 🔴 failed 1, success 10, total 11 11 min Existing failure
idc-jenkins-ci-tidb/integration-ddl-test ✅ all 6 tests passed 4 min 42 sec Fixed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 6 min 3 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 51 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 42 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 54 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 34 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 5, 2022
Closed
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 5, 2022

In response to a cherrypick label: new pull request created: #39613.

ti-chi-bot added a commit that referenced this pull request Dec 5, 2022
@ti-chi-bot
log-backup: do not rewrite shortvalue iif the value is rollback recor…
77776e1 
…d. (#39596) (#39599)

close #39575
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@3pointer 3pointer 3pointer approved these changes

@YuJuncen YuJuncen YuJuncen approved these changes

@Leavrth Leavrth Awaiting requested review from Leavrth

Assignees

No one assigned

Labels

needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

br: pitr restore error:failed to restore meta files: invalid character 'p' looking for beginning of value

5 participants

@joccau @ti-chi-bot @sre-bot @3pointer @YuJuncen