Skip to content

log-backup: do not rewrite shortvalue iif the value is rollback record. (#39596)#39599

Merged
ti-chi-bot merged 5 commits intopingcap:release-6.5from
ti-chi-bot:cherry-pick-39596-to-release-6.5
Dec 5, 2022
Merged

log-backup: do not rewrite shortvalue iif the value is rollback record. (#39596)#39599
ti-chi-bot merged 5 commits intopingcap:release-6.5from
ti-chi-bot:cherry-pick-39596-to-release-6.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Dec 2, 2022

This is an automated cherry-pick of #39596

What problem does this PR solve?

Issue Number: close #39575

Problem Summary:

  • Failed to unmarsher short-value into DbInfo because the meta-kv is rollback record.

What is changed and how it works?

  • Skip rewrite value if the meta-kv is rollback record.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

joccau added 4 commits December 2, 2022 12:06
@ti-chi-bot
debug
a302946 
Signed-off-by: joccau <zak.zhao@pingcap.com>
@ti-chi-bot
don't rewrite short-value if the value is rollback record
8b54e85 
Signed-off-by: joccau <zak.zhao@pingcap.com>
@ti-chi-bot
add more memeber in write cf valud
819c1e6 
Signed-off-by: joccau <zak.zhao@pingcap.com>
@ti-chi-bot
add test cases
fa942dc 
Signed-off-by: joccau <zak.zhao@pingcap.com>
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 2, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Dec 2, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • Leavrth

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Dec 2, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 5, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 5, 2022
@sre-bot sre-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Dec 5, 2022
@joccau
Copy link
Contributor

joccau commented Dec 5, 2022

/merge

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Dec 5, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: fa942dc

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 5, 2022
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Dec 5, 2022

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 77776e1 into pingcap:release-6.5 Dec 5, 2022
@ti-chi-bot ti-chi-bot deleted the cherry-pick-39596-to-release-6.5 branch April 15, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@3pointer 3pointer 3pointer approved these changes

@Leavrth Leavrth Leavrth approved these changes

Assignees

@joccau joccau

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ti-chi-bot @joccau @3pointer @Leavrth @sre-bot