Skip to content

DDL: delete partition table tiflash replica progress from ETCD when truncate table, drop table, set tiflash replica 0#38551

Merged
ti-chi-bot merged 6 commits intopingcap:masterfrom
hehechen:delete_partitoin_etcd
Oct 20, 2022
Merged

DDL: delete partition table tiflash replica progress from ETCD when truncate table, drop table, set tiflash replica 0#38551
ti-chi-bot merged 6 commits intopingcap:masterfrom
hehechen:delete_partitoin_etcd

Conversation

@hehechen
Copy link
Contributor

@hehechen hehechen commented Oct 19, 2022 •
edited
Loading

Signed-off-by: hehechen chentongli@pingcap.com

What problem does this PR solve?

Issue Number: close #38550

Problem Summary:
In this PR, TiFlash replica progress with logical table id can be deleted when table is truncated or dropped. But for partition table, TiFlash replica progress can't be deleted from ETCD.

What is changed and how it works?

  1. Delete TiFlash replica progress of partition tables from ETCD.
  2. Delete TiFlash replica progress from ETCD when set TiFlash replica 0.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

delete partition table progress from etcd
272c897 
Signed-off-by: hehechen <chentongli@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 19, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • breezewish
  • crazycs520

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 19, 2022
@hehechen
Copy link
Contributor Author

hehechen commented Oct 19, 2022

/cc @CalvinNeo @breezewish @windtalker

add ut and fix truncate table
0f81126 
Signed-off-by: hehechen <chentongli@pingcap.com>
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 19, 2022
hehechen added 2 commits October 20, 2022 00:03
fix lint
354b6f9 
Signed-off-by: hehechen <chentongli@pingcap.com>
Merge branch 'master' into delete_partitoin_etcd
4a8c6b6
@hehechen
Copy link
Contributor Author

hehechen commented Oct 20, 2022

/cc @crazycs520

@ti-chi-bot ti-chi-bot requested a review from crazycs520 October 20, 2022 01:58
@hehechen hehechen changed the title DDL: delete partition table progress from etcd DDL: delete partition table progress from ETCD when truncate table, drop table, set tiflash replica 0 Oct 20, 2022
@hehechen hehechen changed the title DDL: delete partition table progress from ETCD when truncate table, drop table, set tiflash replica 0 DDL: delete partition table tiflash replica progress from ETCD when truncate table, drop table, set tiflash replica 0 Oct 20, 2022
@hehechen hehechen mentioned this pull request Oct 20, 2022
Merged
12 tasks
CalvinNeo
CalvinNeo approved these changes Oct 20, 2022
View reviewed changes
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 20, 2022

@CalvinNeo: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 20, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 20, 2022
@breezewish
Copy link
Member

breezewish commented Oct 20, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 20, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 9371ef6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 20, 2022
@ti-chi-bot ti-chi-bot merged commit c52b5a7 into pingcap:master Oct 20, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Oct 20, 2022

TiDB MergeCI notify

🔴 Bad News! [1] CI still failing after this pr merged.
These failed integration tests don't seem to be introduced by the current PR.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🔴 failed 1, success 37, total 38 23 min Existing failure
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 23 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 12 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 9 min 42 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 21 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 4 min 49 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 3 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 34 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 42 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@breezewish
Copy link
Member

breezewish commented Oct 24, 2022

/run-cherry-picker

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 24, 2022
Closed
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 24, 2022

In response to a cherrypick label: new pull request created: #38619.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Oct 24, 2022
@ti-chi-bot
This is an automated cherry-pick of pingcap#38551
49aec61 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 24, 2022
Closed
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 24, 2022

In response to a cherrypick label: new pull request created: #38620.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Oct 24, 2022
@ti-chi-bot
This is an automated cherry-pick of pingcap#38551
c3f4b35 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 24, 2022
Closed
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 24, 2022

In response to a cherrypick label: new pull request created: #38621.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Oct 24, 2022
@ti-chi-bot
This is an automated cherry-pick of pingcap#38551
29af4e1 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 24, 2022

In response to a cherrypick label: new pull request created: #38622.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 24, 2022
Closed
12 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Oct 24, 2022
@ti-chi-bot
This is an automated cherry-pick of pingcap#38551
24326bb 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 24, 2022

In response to a cherrypick label: new pull request could not be created: failed to create pull request against pingcap/tidb#release-5.3 from head ti-chi-bot:cherry-pick-38551-to-release-5.3: the GitHub API request returns a 403 error: {"message":"You have exceeded a secondary rate limit and have been temporarily blocked from content creation. Please retry your request again later.","documentation_url":"https://docs.github.com/rest/overview/resources-in-the-rest-api#secondary-rate-limits"}

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Oct 24, 2022
@ti-chi-bot
This is an automated cherry-pick of pingcap#38551
ded6aab 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 24, 2022

In response to a cherrypick label: new pull request could not be created: failed to create pull request against pingcap/tidb#release-5.4 from head ti-chi-bot:cherry-pick-38551-to-release-5.4: the GitHub API request returns a 403 error: {"message":"You have exceeded a secondary rate limit and have been temporarily blocked from content creation. Please retry your request again later.","documentation_url":"https://docs.github.com/rest/overview/resources-in-the-rest-api#secondary-rate-limits"}

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Oct 24, 2022
@ti-chi-bot
This is an automated cherry-pick of pingcap#38551
a793368 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 24, 2022

In response to a cherrypick label: new pull request could not be created: failed to create pull request against pingcap/tidb#release-6.1 from head ti-chi-bot:cherry-pick-38551-to-release-6.1: the GitHub API request returns a 403 error: {"message":"You have exceeded a secondary rate limit and have been temporarily blocked from content creation. Please retry your request again later.","documentation_url":"https://docs.github.com/rest/overview/resources-in-the-rest-api#secondary-rate-limits"}

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Oct 24, 2022
@ti-chi-bot
This is an automated cherry-pick of pingcap#38551
2ff595c 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@breezewish breezewish breezewish approved these changes

@crazycs520 crazycs520 crazycs520 approved these changes

@windtalker windtalker Awaiting requested review from windtalker

+1 more reviewer

@CalvinNeo CalvinNeo CalvinNeo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Delete TiFlash replica progress of partition tables from ETCD

6 participants

@hehechen @ti-chi-bot @breezewish @sre-bot @CalvinNeo @crazycs520