Skip to content

ddl: Delete TiFlash sync status from etcd when table is truncated or dropped#37184

Merged
ti-chi-bot merged 14 commits intopingcap:masterfrom
CalvinNeo:fix5265
Sep 7, 2022
Merged

ddl: Delete TiFlash sync status from etcd when table is truncated or dropped#37184
ti-chi-bot merged 14 commits intopingcap:masterfrom
CalvinNeo:fix5265

Conversation

@CalvinNeo
Copy link
Member

@CalvinNeo CalvinNeo commented Aug 17, 2022 •
edited
Loading

Signed-off-by: CalvinNeo calvinneo1995@gmail.com

What problem does this PR solve?

Issue Number: close #37168

Problem Summary:

If a table with TiFlash replica is dropped of truncated, we have to delete its progress in etcd. Otherwise will cause too much obsolette keys in etcd if there are frequent dropping/truncating, which can lead to etcd oom.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@CalvinNeo
f
1cfd6d5 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 17, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lcwangchao
  • zimulala

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 17, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 17, 2022 •
edited by sre-bot
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/11456e101e13ac3a4c1b276497d70212996c5a53

@CalvinNeo
f
1ec2ce5 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
f
cd25c71 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
Copy link
Member Author

CalvinNeo commented Aug 17, 2022

/cc @breezewish @crazycs520

@CalvinNeo
f
c0f0e15 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
Copy link
Member Author

CalvinNeo commented Aug 17, 2022

/cc @lcwangchao

@ti-chi-bot ti-chi-bot requested a review from lcwangchao August 17, 2022 16:12
@breezewish breezewish self-assigned this Aug 17, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 19, 2022
@CalvinNeo
restore
20fdc5f 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 19, 2022
@ti-srebot ti-srebot mentioned this pull request Sep 7, 2022
Closed
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 7, 2022
@CalvinNeo @ti-srebot
cherry pick pingcap#37184 to release-5.2
29baaed 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

ti-srebot commented Sep 7, 2022

cherry pick to release-5.2 in PR #37675

@ti-srebot ti-srebot mentioned this pull request Sep 7, 2022
Closed
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 7, 2022
@CalvinNeo @ti-srebot
cherry pick pingcap#37184 to release-5.3
c3edb9f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

ti-srebot commented Sep 7, 2022

cherry pick to release-5.3 in PR #37677

@ti-srebot ti-srebot mentioned this pull request Sep 7, 2022
Closed
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 7, 2022
@CalvinNeo @ti-srebot
cherry pick pingcap#37184 to release-5.4
38776f4 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

ti-srebot commented Sep 7, 2022

cherry pick to release-5.4 in PR #37678

@ti-srebot ti-srebot mentioned this pull request Sep 7, 2022
Closed
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 7, 2022
@CalvinNeo @ti-srebot
cherry pick pingcap#37184 to release-6.0
063bf99 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

ti-srebot commented Sep 7, 2022

cherry pick to release-6.0 in PR #37679

@ti-srebot ti-srebot mentioned this pull request Sep 7, 2022
Closed
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 7, 2022
@CalvinNeo @ti-srebot
cherry pick pingcap#37184 to release-6.1
84c0026 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

ti-srebot commented Sep 7, 2022

cherry pick to release-6.1 in PR #37680

@ti-srebot ti-srebot mentioned this pull request Sep 7, 2022
Closed
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 7, 2022
@CalvinNeo @ti-srebot
cherry pick pingcap#37184 to release-6.2
e729304 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

ti-srebot commented Sep 7, 2022

cherry pick to release-6.2 in PR #37681

@CalvinNeo
Copy link
Member Author

CalvinNeo commented Sep 30, 2022

/cherry-pick release-6.1

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 30, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 30, 2022

@CalvinNeo: new pull request created: #38268.

Details

In response to this:

/cherry-pick release-6.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

This was referenced Oct 19, 2022
Closed
Merged
This was referenced Oct 24, 2022
Closed
Closed
Closed
Closed
ti-chi-bot added a commit that referenced this pull request Oct 28, 2022
@ti-chi-bot
ddl: Delete TiFlash sync status from etcd when table is truncated or …
ce40035 
…dropped (#37184) (#38268)

close #37168
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lcwangchao lcwangchao lcwangchao approved these changes

@zimulala zimulala zimulala approved these changes

@crazycs520 crazycs520 crazycs520 approved these changes

@breezewish breezewish Awaiting requested review from breezewish

Assignees

@breezewish breezewish

Labels

needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

/tiflash/table/sync not cleared

7 participants

@CalvinNeo @ti-chi-bot @breezewish @ti-srebot @lcwangchao @zimulala @crazycs520