Skip to content

ddl: Delete TiFlash sync status from etcd when table is truncated or dropped (#37184)#37675

Closed
ti-srebot wants to merge 1 commit intopingcap:release-5.2from
ti-srebot:release-5.2-4cb0d1f7a00e
Closed

ddl: Delete TiFlash sync status from etcd when table is truncated or dropped (#37184)#37675
ti-srebot wants to merge 1 commit intopingcap:release-5.2from
ti-srebot:release-5.2-4cb0d1f7a00e

Conversation

@ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Sep 7, 2022 •
edited
Loading

cherry-pick #37184 to release-5.2
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/37675

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/37675:release-5.2-4cb0d1f7a00e

Signed-off-by: CalvinNeo calvinneo1995@gmail.com

What problem does this PR solve?

Issue Number: close #37168

Problem Summary:

If a table with TiFlash replica is dropped of truncated, we have to delete its progress in etcd. Otherwise will cause too much obsolette keys in etcd if there are frequent dropping/truncating, which can lead to etcd oom.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@CalvinNeo @ti-srebot
cherry pick pingcap#37184 to release-5.2
29baaed 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 7, 2022

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 7, 2022

@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-srebot
Copy link
Contributor Author

ti-srebot commented Sep 7, 2022

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 7, 2022
@ti-srebot ti-srebot mentioned this pull request Sep 7, 2022
Merged
12 tasks
@ti-srebot ti-srebot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/5.2-cherry-pick labels Sep 7, 2022
@ti-srebot ti-srebot added this to the v5.2.4 milestone Sep 7, 2022
@ti-chi-bot ti-chi-bot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 7, 2022
@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 7, 2022
@VelocityLight
Copy link

VelocityLight commented Sep 21, 2022

This pull request is closed because it's related version has closed automatic cherry-picking.
If it's still needed, you can reopen it or just regenerate it using bot,
see:

You can find more details at:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@breezewish breezewish Awaiting requested review from breezewish

@crazycs520 crazycs520 Awaiting requested review from crazycs520

@lcwangchao lcwangchao Awaiting requested review from lcwangchao

@zimulala zimulala Awaiting requested review from zimulala

Assignees

@CalvinNeo CalvinNeo

Labels

do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/5.2-cherry-pick

Projects

None yet

Milestone

v5.2.4

Development

Successfully merging this pull request may close these issues.

4 participants

@ti-srebot @ti-chi-bot @VelocityLight @CalvinNeo