Skip to content

executor: fix the missing Grantor when querying mysql.tables_priv#38461

Merged
ti-chi-bot merged 7 commits intopingcap:masterfrom
CbcWestwolf:fix_issue38293
Oct 20, 2022
Merged

executor: fix the missing Grantor when querying mysql.tables_priv#38461
ti-chi-bot merged 7 commits intopingcap:masterfrom
CbcWestwolf:fix_issue38293

Conversation

@CbcWestwolf
Copy link
Member

@CbcWestwolf CbcWestwolf commented Oct 13, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #38293

Problem Summary:

When executing grant, we create an internal session to start internal transaction, but does not pass the user in.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix a bug about missing `grantor` in `mysql.tables_priv`.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 13, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • xhebox
  • xiongjiwei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 13, 2022
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 20, 2022
@CbcWestwolf CbcWestwolf marked this pull request as ready for review October 20, 2022 03:23
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. labels Oct 20, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 20, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 20, 2022
@xhebox
Copy link
Contributor

xhebox commented Oct 20, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 20, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: c19fc41

@ti-chi-bot ti-chi-bot added status/can-merge Indicates a PR has been approved by a committer. needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.3 labels Oct 20, 2022
@ti-chi-bot ti-chi-bot merged commit 17c7bcc into pingcap:master Oct 20, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 20, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 20, 2022

In response to a cherrypick label: new pull request created: #38560.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Oct 20, 2022
@CbcWestwolf @ti-chi-bot
This is an automated cherry-pick of pingcap#38461
02423dd 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 20, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 20, 2022

In response to a cherrypick label: new pull request created: #38561.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Oct 20, 2022
@CbcWestwolf @ti-chi-bot
This is an automated cherry-pick of pingcap#38461
b8f054f 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 20, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 20, 2022

In response to a cherrypick label: new pull request created: #38562.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 20, 2022
Closed
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 20, 2022

In response to a cherrypick label: new pull request created: #38563.

@CbcWestwolf CbcWestwolf deleted the fix_issue38293 branch October 20, 2022 03:52
@sre-bot
Copy link
Contributor

sre-bot commented Oct 20, 2022

TiDB MergeCI notify

🔴 Bad News! [1] CI still failing after this pr merged.
These failed integration tests don't seem to be introduced by the current PR.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🔴 failed 1, success 37, total 38 26 min Existing failure
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 23 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 16 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 10 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 23 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 4 min 55 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 3 min 57 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 35 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 46 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@CbcWestwolf
Copy link
Member Author

CbcWestwolf commented Oct 31, 2022

/cherry-pick-invite

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 31, 2022

@CbcWestwolf Please accept the invitation then you can push to the cherry-pick pull requests.
Comment with "/cherry-pick-invite" if the invitation is expired.
https://github.com/ti-chi-bot/tidb/invitations

ti-chi-bot added a commit that referenced this pull request Oct 31, 2022
@ti-chi-bot
executor: fix the missing Grantor when querying mysql.`tables_pri…
31f5579 
…v` (#38461) (#38560)

close #38293
ti-chi-bot added a commit that referenced this pull request Oct 31, 2022
@ti-chi-bot
executor: fix the missing Grantor when querying mysql.`tables_pri…
7378dcd 
…v` (#38461) (#38562)

close #38293
ti-chi-bot added a commit that referenced this pull request Oct 31, 2022
@ti-chi-bot
executor: fix the missing Grantor when querying mysql.`tables_pri…
6ebef7a 
…v` (#38461) (#38561)

close #38293
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xhebox xhebox xhebox approved these changes

+1 more reviewer

@xiongjiwei xiongjiwei xiongjiwei approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Grantor column in mysql.tables_priv is always NULL

5 participants

@CbcWestwolf @ti-chi-bot @xhebox @sre-bot @xiongjiwei