Skip to content

executor: fix the missing Grantor when querying mysql.tables_priv (#38461)#38563

Closed
ti-chi-bot wants to merge 2 commits intopingcap:release-6.3from
ti-chi-bot:cherry-pick-38461-to-release-6.3
Closed

executor: fix the missing Grantor when querying mysql.tables_priv (#38461)#38563
ti-chi-bot wants to merge 2 commits intopingcap:release-6.3from
ti-chi-bot:cherry-pick-38461-to-release-6.3

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Oct 20, 2022

This is an automated cherry-pick of #38461

What problem does this PR solve?

Issue Number: close #38293

Problem Summary:

When executing grant, we create an internal session to start internal transaction, but does not pass the user in.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix a bug about missing `grantor` in `mysql.tables_priv`.

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Oct 20, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CbcWestwolf
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved labels Oct 20, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 20, 2022
Merged
12 tasks
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-6.3 labels Oct 20, 2022
@xhebox xhebox requested a review from xiongjiwei October 28, 2022 09:39
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 28, 2022
@CbcWestwolf
Copy link
Member

CbcWestwolf commented Oct 31, 2022

/run-unit-test

1 similar comment
@CbcWestwolf
Copy link
Member

CbcWestwolf commented Oct 31, 2022

/run-unit-test

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 31, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/cherry-pick-not-approved and removed do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. labels Nov 4, 2022
@xhebox
Copy link
Contributor

xhebox commented Nov 15, 2022

/merge

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Nov 15, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: ef1cb3b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 15, 2022
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Dec 29, 2022 •
edited
Loading

@ti-chi-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/mysql-test ef1cb3b link true /test mysql-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@xhebox
Copy link
Contributor

xhebox commented Dec 29, 2022

/retest

@xhebox
Copy link
Contributor

xhebox commented Dec 29, 2022

/close

6.3 is not maintained.

@ti-chi-bot ti-chi-bot closed this Dec 29, 2022
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Dec 29, 2022

@xhebox: Closed this PR.

Details

In response to this:

/close

6.3 is not maintained.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot deleted the cherry-pick-38461-to-release-6.3 branch April 15, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xhebox xhebox xhebox approved these changes

@CbcWestwolf CbcWestwolf CbcWestwolf approved these changes

@xiongjiwei xiongjiwei Awaiting requested review from xiongjiwei

Assignees

@CbcWestwolf CbcWestwolf

Labels

do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ti-chi-bot @CbcWestwolf @xhebox @VelocityLight