txn: rename snapshot related methods in txnManager. by SpadeA-Tang · Pull Request #35912 · pingcap/tidb

SpadeA-Tang · 2022-07-04T06:14:13Z

Signed-off-by: SpadeA-Tang u6748471@anu.edu.au

What problem does this PR solve?

Issue Number: close #35915

Problem Summary:

What is changed and how it works?

Rename GetReadSnapshot to GetSnapshotWithStmtReadTS and GetForUpdateSnapshot to GetSnapshotWithStmtForUpdateTS in txnManager.

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au>

ti-chi-bot · 2022-07-04T06:14:14Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

lcwangchao
youjiali1995

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

sre-bot · 2022-07-04T06:28:31Z

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/acaa070a4e6cf46e228f5c633b3366607dabaff1

youjiali1995 · 2022-07-04T06:48:38Z

sessiontxn/interface.go

-	GetReadSnapshot() (kv.Snapshot, error)
-	// GetForUpdateSnapshot get snapshot with for update ts
-	GetForUpdateSnapshot() (kv.Snapshot, error)
+	// GetSnapshotWithStmtReadTS get snapshot with read ts


Suggested change

// GetSnapshotWithStmtReadTS get snapshot with read ts

// GetSnapshotWithStmtReadTS gets snapshot with read ts

youjiali1995 · 2022-07-04T06:48:46Z

sessiontxn/interface.go

-	GetForUpdateSnapshot() (kv.Snapshot, error)
+	// GetSnapshotWithStmtReadTS get snapshot with read ts
+	GetSnapshotWithStmtReadTS() (kv.Snapshot, error)
+	// GetSnapshotWithStmtForUpdateTS get snapshot with for update ts


Suggested change

// GetSnapshotWithStmtForUpdateTS get snapshot with for update ts

// GetSnapshotWithStmtForUpdateTS gets snapshot with for update ts

youjiali1995 · 2022-07-04T06:48:56Z

session/txnmanager.go

 }

-func (m *txnManager) GetReadSnapshot() (kv.Snapshot, error) {
+// GetSnapshotWithStmtReadTS get snapshot with read ts


Suggested change

// GetSnapshotWithStmtReadTS get snapshot with read ts

// GetSnapshotWithStmtReadTS gets snapshot with read ts

youjiali1995 · 2022-07-04T06:49:07Z

session/txnmanager.go

 }

-func (m *txnManager) GetForUpdateSnapshot() (kv.Snapshot, error) {
+// GetSnapshotWithStmtForUpdateTS get snapshot with for update ts


Suggested change

// GetSnapshotWithStmtForUpdateTS get snapshot with for update ts

// GetSnapshotWithStmtForUpdateTS gets snapshot with for update ts

Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au>

hawkingrei · 2022-07-04T07:08:54Z

/run-mysql-test

xhebox · 2022-07-04T09:00:35Z

/merge

ti-chi-bot · 2022-07-04T09:00:38Z

This pull request has been accepted and is ready to merge.

Details

Commit hash: 996897d

lcwangchao · 2022-07-04T09:03:24Z

/merge

SpadeA-Tang · 2022-07-04T15:21:55Z

/run-check_dev_2

hawkingrei · 2022-07-04T16:33:03Z

/run-check_dev_2

SpadeA-Tang · 2022-07-05T02:10:47Z

/run-unit-test

SpadeA-Tang · 2022-07-05T02:27:29Z

/run-mysql-test

sre-bot · 2022-07-05T05:09:02Z

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name	Result	Duration	Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test	🟥 failed 2, success 9, total 11	18 min	New failing
idc-jenkins-ci/integration-cdc-test	🟢 all 35 tests passed	25 min	Existing passed
idc-jenkins-ci-tidb/common-test	🟢 all 12 tests passed	11 min	Existing passed
idc-jenkins-ci-tidb/integration-ddl-test	🟢 all 6 tests passed	6 min 45 sec	Existing passed
idc-jenkins-ci-tidb/tics-test	🟢 all 1 tests passed	6 min 41 sec	Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1	🟢 all 26 tests passed	5 min 41 sec	Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2	🟢 all 28 tests passed	5 min 34 sec	Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test	🟢 all 1 tests passed	3 min 21 sec	Existing passed
idc-jenkins-ci-tidb/mybatis-test	🟢 all 1 tests passed	3 min 12 sec	Existing passed
idc-jenkins-ci-tidb/plugin-test	🟢 build success, plugin test success	4min	Existing passed

* upstream/master: (77 commits) infoschema: add a simply store for DM's SchemaTracker (pingcap#35954) planner: refactor "access object" related logic and prepare for binary plan (pingcap#35890) telemetry: Initialize telemetry asynchronously (pingcap#35898) sessionctx/variable: convert TiDBLogFileMaxDays and TiDBConfig to ScopeInstance (pingcap#35733) session, sessionctx/variable: ensure sysvars are always in lower case (pingcap#35659) *: add telemetry support for multi-schema change (pingcap#35977) topsql: compress plan instead of dropping it (pingcap#35973) *: use pdqsort to improve sort performance (pingcap#34404) ddl: refine GetDDLInfo function (pingcap#35969) *: Make the code cleaner in session.ExecutePreparedStmt (pingcap#35943) ddl: remove `onDropIndexes` (pingcap#35960) ddl: refine history job code (pingcap#35967) sessionctx,kv,planner: add system variable for fine_grained_shuffle (pingcap#35256) *: change remote cache (pingcap#35968) *: enable gosec (pingcap#35873) plancodec: fix a miss case in conversion (pingcap#35957) ddl: support drop indexes for multi-schema change (pingcap#35883) pdutil: fix unstable test TestPauseSchedulersByKeyRange (pingcap#35949) br: optimize communication with tikv stores. pingcap#31722 (pingcap#35147) txn: rename snapshot related methods in txnManager. (pingcap#35912) ...

update

2bd5160

Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au>

ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Jul 4, 2022

lcwangchao approved these changes Jul 4, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 4, 2022

youjiali1995 reviewed Jul 4, 2022

View reviewed changes

SpadeA-Tang added 2 commits July 4, 2022 14:50

update comment

6c47af8

Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au>

update comment

996897d

Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au>

youjiali1995 approved these changes Jul 4, 2022

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 4, 2022

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 4, 2022

Merge branch 'master' into renameSnapshot

ee84626

Merge branch 'master' into renameSnapshot

3a648c5

Merge branch 'master' into renameSnapshot

4bfb307

ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 5, 2022

Merge branch 'master' into renameSnapshot

4a49ba1

ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 5, 2022

Merge branch 'master' into renameSnapshot

acaa070

ti-chi-bot merged commit 441c9cd into pingcap:master Jul 5, 2022

	// GetSnapshotWithStmtReadTS get snapshot with read ts
	// GetSnapshotWithStmtReadTS gets snapshot with read ts

	// GetSnapshotWithStmtForUpdateTS get snapshot with for update ts
	// GetSnapshotWithStmtForUpdateTS gets snapshot with for update ts

Conversation

SpadeA-Tang commented Jul 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

Uh oh!

ti-chi-bot commented Jul 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sre-bot commented Jul 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

youjiali1995 Jul 4, 2022

Choose a reason for hiding this comment

Uh oh!

youjiali1995 Jul 4, 2022

Choose a reason for hiding this comment

Uh oh!

youjiali1995 Jul 4, 2022

Choose a reason for hiding this comment

Uh oh!

youjiali1995 Jul 4, 2022

Choose a reason for hiding this comment

Uh oh!

hawkingrei commented Jul 4, 2022

Uh oh!

xhebox commented Jul 4, 2022

Uh oh!

ti-chi-bot commented Jul 4, 2022

Uh oh!

lcwangchao commented Jul 4, 2022

Uh oh!

SpadeA-Tang commented Jul 4, 2022

Uh oh!

hawkingrei commented Jul 4, 2022

Uh oh!

SpadeA-Tang commented Jul 5, 2022

Uh oh!

SpadeA-Tang commented Jul 5, 2022

Uh oh!

sre-bot commented Jul 5, 2022

TiDB MergeCI notify

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

SpadeA-Tang commented Jul 4, 2022 •

edited

Loading

ti-chi-bot commented Jul 4, 2022 •

edited

Loading

sre-bot commented Jul 4, 2022 •

edited

Loading