Skip to content

planner: refactor "access object" related logic and prepare for binary plan#35890

Merged
ti-chi-bot merged 9 commits intopingcap:masterfrom
time-and-fate:visual-plan-part1
Jul 6, 2022
Merged

planner: refactor "access object" related logic and prepare for binary plan#35890
ti-chi-bot merged 9 commits intopingcap:masterfrom
time-and-fate:visual-plan-part1

Conversation

@time-and-fate
Copy link
Member

@time-and-fate time-and-fate commented Jul 1, 2022

What problem does this PR solve?

Issue Number: ref #35888 ref #35889

What is changed and how it works?

  • Make "access object" related code cleaner.
  • Make the new AccessObject be able to be transmitted by protobuf.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 1, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • winoros
  • xuyifangreeneyes

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 1, 2022
@time-and-fate
Copy link
Member Author

time-and-fate commented Jul 1, 2022

/run-unit-test

@sre-bot
Copy link
Contributor

sre-bot commented Jul 1, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/646745c468ae46683f63f178c4f1786c74d5b0d7

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 4, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 6, 2022
@time-and-fate
Copy link
Member Author

time-and-fate commented Jul 6, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 6, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 36c40a4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 6, 2022
@time-and-fate
Copy link
Member Author

time-and-fate commented Jul 6, 2022

/run-unit-test

@time-and-fate
Copy link
Member Author

time-and-fate commented Jul 6, 2022

/run-mysql-test

@time-and-fate
Copy link
Member Author

time-and-fate commented Jul 6, 2022

/run-check_dev_2

@time-and-fate
Copy link
Member Author

time-and-fate commented Jul 6, 2022

/run-mysql-test

@time-and-fate
Copy link
Member Author

time-and-fate commented Jul 6, 2022

/run-mysql-test

@time-and-fate
Copy link
Member Author

time-and-fate commented Jul 6, 2022

/run-mysql-test

@time-and-fate
Copy link
Member Author

time-and-fate commented Jul 6, 2022

💢💢💢

@time-and-fate
Copy link
Member Author

time-and-fate commented Jul 6, 2022

/run-mysql-test

@ti-chi-bot ti-chi-bot merged commit 07f1242 into pingcap:master Jul 6, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 6, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [1] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test ✅ all 11 tests passed 22 min Fixed
idc-jenkins-ci/integration-cdc-test 🟢 all 35 tests passed 28 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 12 min Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 5 min 57 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 46 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 14 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 33 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 2 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 52 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

morgo added a commit to morgo/tidb that referenced this pull request Jul 6, 2022
@morgo
Merge remote-tracking branch 'upstream/master' into improve-skip-init
10c7409 
* upstream/master: (77 commits)
  infoschema: add a simply store for DM's SchemaTracker (pingcap#35954)
  planner: refactor "access object" related logic and prepare for binary plan (pingcap#35890)
  telemetry: Initialize telemetry asynchronously (pingcap#35898)
  sessionctx/variable: convert TiDBLogFileMaxDays and TiDBConfig to ScopeInstance (pingcap#35733)
  session, sessionctx/variable: ensure sysvars are always in lower case (pingcap#35659)
  *: add telemetry support for multi-schema change (pingcap#35977)
  topsql: compress plan instead of dropping it (pingcap#35973)
  *: use pdqsort to improve sort performance (pingcap#34404)
  ddl: refine GetDDLInfo function (pingcap#35969)
  *: Make the code cleaner in session.ExecutePreparedStmt (pingcap#35943)
  ddl: remove `onDropIndexes` (pingcap#35960)
  ddl: refine history job code (pingcap#35967)
  sessionctx,kv,planner: add system variable for fine_grained_shuffle (pingcap#35256)
  *: change remote cache (pingcap#35968)
  *: enable gosec (pingcap#35873)
  plancodec: fix a miss case in conversion (pingcap#35957)
  ddl: support drop indexes for multi-schema change (pingcap#35883)
  pdutil: fix unstable test TestPauseSchedulersByKeyRange (pingcap#35949)
  br: optimize communication with tikv stores. pingcap#31722 (pingcap#35147)
  txn: rename snapshot related methods in txnManager. (pingcap#35912)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@winoros winoros winoros approved these changes

+1 more reviewer

@xuyifangreeneyes xuyifangreeneyes xuyifangreeneyes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@time-and-fate @ti-chi-bot @sre-bot @winoros @xuyifangreeneyes