Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
3686048 to
395032b
Compare
|
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/fe110b13a33257782aaee3b65c601533de54334d |
d818c89 to
04bb239
Compare
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
04bb239 to
7f9cbe1
Compare
I will create another pr to solve it. |
|
/run-check_dev_2 |
2 similar comments
|
/run-check_dev_2 |
|
/run-check_dev_2 |
| if arg0 < 0 { | ||
| break | ||
| return res, false, nil | ||
| } | ||
| if types.CompareInt64(arg0, arg1) == 0 { | ||
| res = 1 |
There was a problem hiding this comment.
These patterns feels even more weird than before. Some code directly return in the switch block, and some relies on return ... at the very end of the function. What do you think?
There was a problem hiding this comment.
break in the switch is so weird. it has two way to fix it.
1、diectly replace with return
2、remove this switch branch. some of switch branch is useless.
3、refactor the code
I do minimal changes to keep code review easy. but I think it still needs to improve.
There was a problem hiding this comment.
BTW, Adding break in the switch is a code style of C/C++？
There was a problem hiding this comment.
BTW, Adding
breakin theswitchis a code style ofC/C++？
Of course. Since case in c/cpp will fall-through by default, so it is natural to use break everywhere. It is a like return for switch block.
Go does not need to use break every case, but you can still use break to "return from the switch block". So when you "jump out of the/return from" switch block, the execution continues from the code below the switch block.
There was a problem hiding this comment.
I think this change is fine because the code is simple enough.
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
|
/merge |
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 070c4e0 |
…vars * upstream/master: (28 commits) *: enable unconvert (pingcap#35821) log-backup: check timezone when using datatime format ts string (pingcap#35811) planner: support the leading hint for outer join (pingcap#35264) lightning: revert new policy of allocating rowid and refine it later (pingcap#35817) txn: manage the initialization of RCCheckTS by transaction context provider (pingcap#35554) ddl: make output field name in `show tables/databases stmt` compatible with mysql (pingcap#35136) txn: remove `legacy.SimpleTxnContextProvider` (pingcap#35667) txn: fix the error message if retry could not be used for rc check ts (pingcap#35474) *: support canceling DDL statements with KILL (pingcap#35803) lightning: avoid extracting db schema when schema file is not provided (pingcap#35783) *: enable all gosimples (pingcap#35762) tools/check: skip 'tests' directory in 'make ut' (pingcap#35800) metrics: add loading region cache duration (pingcap#34679) ddl: DROP TABLE/VIEW/SEQUENCE now use XXXStmt as parameter (pingcap#35741) types: fix incompatible implementation of jsonpath extraction (pingcap#35320) planner: fix TRACE PLAN TARGET = 'estimation' panic when meeting partition table (pingcap#35743) *: Add `testfork.RunTest` to run multiple tests in one function (pingcap#35746) sessionctx/variable: add tests to ensure skipInit can be removed (pingcap#35703) helper: request another PD if one of them is unavailable (pingcap#35750) metrics: add cached table related metrics to grafana panel (pingcap#34718) ...
Signed-off-by: Weizhen Wang wangweizhen@pingcap.com
What problem does this PR solve?
Issue Number: ref #35345
Problem Summary:
What is changed and how it works?
Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.