planner: support the leading hint for outer join#35264
Merged
ti-chi-bot merged 18 commits intopingcap:masterfrom Jun 29, 2022
Merged
planner: support the leading hint for outer join#35264ti-chi-bot merged 18 commits intopingcap:masterfrom
ti-chi-bot merged 18 commits intopingcap:masterfrom
Conversation
Member
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
…OuterJoinLeadingHint
…o supportOuterJoinLeadingHint
Reminiscent
commented
Jun 14, 2022
| if len(res.input) != len(res.output) { | ||
| return res, errors.New(fmt.Sprintf("Number of test input cases %d does not match test output cases %d", len(res.input), len(res.output))) | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
The change in this file is same as #35369
qw4990
approved these changes
Jun 15, 2022
Contributor
|
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/cd073216a675d773208134146561b0ec4be503ff |
winoros
reviewed
Jun 24, 2022
Member
winoros
left a comment
There was a problem hiding this comment.
We need to document that for the case t1 left join (t2, t3, t4), the leading hint would raise a warning since the left join divides the group into two.
winoros
approved these changes
Jun 24, 2022
Contributor
Author
|
/merge |
Member
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 96d796d |
Contributor
TiDB MergeCI notify✅ Well Done! New fixed [1] after this pr merged.
|
morgo
added a commit
to morgo/tidb
that referenced
this pull request
Jun 29, 2022
…vars * upstream/master: (28 commits) *: enable unconvert (pingcap#35821) log-backup: check timezone when using datatime format ts string (pingcap#35811) planner: support the leading hint for outer join (pingcap#35264) lightning: revert new policy of allocating rowid and refine it later (pingcap#35817) txn: manage the initialization of RCCheckTS by transaction context provider (pingcap#35554) ddl: make output field name in `show tables/databases stmt` compatible with mysql (pingcap#35136) txn: remove `legacy.SimpleTxnContextProvider` (pingcap#35667) txn: fix the error message if retry could not be used for rc check ts (pingcap#35474) *: support canceling DDL statements with KILL (pingcap#35803) lightning: avoid extracting db schema when schema file is not provided (pingcap#35783) *: enable all gosimples (pingcap#35762) tools/check: skip 'tests' directory in 'make ut' (pingcap#35800) metrics: add loading region cache duration (pingcap#34679) ddl: DROP TABLE/VIEW/SEQUENCE now use XXXStmt as parameter (pingcap#35741) types: fix incompatible implementation of jsonpath extraction (pingcap#35320) planner: fix TRACE PLAN TARGET = 'estimation' panic when meeting partition table (pingcap#35743) *: Add `testfork.RunTest` to run multiple tests in one function (pingcap#35746) sessionctx/variable: add tests to ensure skipInit can be removed (pingcap#35703) helper: request another PD if one of them is unavailable (pingcap#35750) metrics: add cached table related metrics to grafana panel (pingcap#34718) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #29932
Problem Summary:
Support the leading hint for outer join
What is changed and how it works?
If the query contains the outer join. We will check whether there exists the join conditions between the tables which the leading hint specify. If there is no join conditions, the leading hint will fail. Otherwise, it can work.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.