Skip to content

executor/infoschema_reader.go: skip the unidentifiable table-attributes#34129

Merged
ti-chi-bot merged 3 commits intopingcap:masterfrom
AndreMouche:invalid_table_attributes
Apr 22, 2022
Merged

executor/infoschema_reader.go: skip the unidentifiable table-attributes#34129
ti-chi-bot merged 3 commits intopingcap:masterfrom
AndreMouche:invalid_table_attributes

Conversation

@AndreMouche
Copy link
Contributor

@AndreMouche AndreMouche commented Apr 20, 2022 •
edited
Loading

Signed-off-by: shirly AndreMouche@126.com

What problem does this PR solve?

Issue Number: close #33665

Problem Summary:
TiDB uses region-rule to store the attributes of the table, and TiDB returns error when it can not identify the region-rule(which is not created by TiDB). This PR will skip and leave a warning log when meet the unidentifiable rule(table-attributes).

What is changed and how it works?

Check List

Tests

  • Unit test

  • Manual test (add detailed scripts or steps below)

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@AndreMouche
executor/infoschema_reader.go: skip the region-rule which is not gene…
91f3a3d 
…rated by TiDB

Signed-off-by: shirly <AndreMouche@126.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 20, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 20, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Apr 20, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/14f7d8df8ccf8a5e009bf3bfe4f1deb559385860

@nolouch
Copy link
Member

nolouch commented Apr 20, 2022

cc @rleungx

@rleungx
Copy link
Member

rleungx commented Apr 20, 2022 •
edited
Loading

After discussion with @nolouch before, I think another option is we record the source, if the source is not TiDB, we can omit this check and give a warning.

@rleungx
Copy link
Member

rleungx commented Apr 20, 2022

But just giving a warning is ok to me.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 21, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 21, 2022
@hawkingrei
Copy link
Member

hawkingrei commented Apr 22, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 22, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 91f3a3d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 22, 2022
@ti-chi-bot ti-chi-bot merged commit e6d55e1 into pingcap:master Apr 22, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Apr 22, 2022

TiDB MergeCI notify

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🟢 all 11 tests passed 10 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 7 min 22 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 7 min 22 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 7 min 22 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 7 min 20 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 7 min 6 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 4 min 1 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 47 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

espresso98 pushed a commit to espresso98/tidb that referenced this pull request Apr 25, 2022
@AndreMouche @espresso98
executor/infoschema_reader.go: skip the unidentifiable table-attribut…
db12314 
…es (pingcap#34129)

close pingcap#33665
@overvenus overvenus added needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-6.0 labels Apr 27, 2022
@overvenus
Copy link
Member

overvenus commented Apr 27, 2022

/run-cherry-picker

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 27, 2022
@AndreMouche @ti-srebot
cherry pick pingcap#34129 to release-5.3
ba8f0ab 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 27, 2022
Closed
2 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Apr 27, 2022

cherry pick to release-5.3 in PR #34270

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 27, 2022
@AndreMouche @ti-srebot
cherry pick pingcap#34129 to release-5.4
6842a0e 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 27, 2022
Merged
2 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Apr 27, 2022

cherry pick to release-5.4 in PR #34271

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 27, 2022
@AndreMouche @ti-srebot
cherry pick pingcap#34129 to release-6.0
e868169 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 27, 2022
Closed
2 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Apr 27, 2022

cherry pick to release-6.0 in PR #34272

ti-chi-bot pushed a commit that referenced this pull request Apr 28, 2022
@ti-srebot
executor/infoschema_reader.go: skip the unidentifiable table-attribut…
1315e32 
…es (#34129) (#34271)

close #33665
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nolouch nolouch nolouch approved these changes

@rleungx rleungx rleungx approved these changes

Assignees

No one assigned

Labels

needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Checks for the region label id should be more robust

8 participants

@AndreMouche @ti-chi-bot @sre-bot @nolouch @rleungx @hawkingrei @overvenus @ti-srebot