Skip to content

executor/infoschema_reader.go: skip the unidentifiable table-attributes (#34129)#34270

Closed
ti-srebot wants to merge 1 commit intopingcap:release-5.3from
ti-srebot:release-5.3-e6d55e14fa56
Closed

executor/infoschema_reader.go: skip the unidentifiable table-attributes (#34129)#34270
ti-srebot wants to merge 1 commit intopingcap:release-5.3from
ti-srebot:release-5.3-e6d55e14fa56

Conversation

@ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Apr 27, 2022 •
edited
Loading

cherry-pick #34129 to release-5.3
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/34270

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/34270:release-5.3-e6d55e14fa56

Signed-off-by: shirly AndreMouche@126.com

What problem does this PR solve?

Issue Number: close #33665

Problem Summary:
TiDB uses region-rule to store the attributes of the table, and TiDB returns error when it can not identify the region-rule(which is not created by TiDB). This PR will skip and leave a warning log when meet the unidentifiable rule(table-attributes).

What is changed and how it works?

Check List

Tests

  • Unit test

  • Manual test (add detailed scripts or steps below)

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@AndreMouche @ti-srebot
cherry pick pingcap#34129 to release-5.3
ba8f0ab 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 27, 2022

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 27, 2022

@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-srebot
Copy link
Contributor Author

ti-srebot commented Apr 27, 2022

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 27, 2022
@ti-srebot ti-srebot mentioned this pull request Apr 27, 2022
Merged
2 tasks
@ti-srebot ti-srebot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/5.3-cherry-pick labels Apr 27, 2022
@ti-srebot ti-srebot requested review from nolouch and rleungx April 27, 2022 05:19
@ti-srebot ti-srebot added this to the v5.3.1 milestone Apr 27, 2022
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 27, 2022
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Apr 27, 2022

@AndreMouche you're already a collaborator in bot's repo.

@VelocityLight
Copy link

VelocityLight commented Sep 21, 2022

This pull request is closed because the related issue is triaged "Won't Fix".
If it's still needed, you can reopen it or just regenerate it using bot,
see:

You can find more details at:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nolouch nolouch Awaiting requested review from nolouch

@rleungx rleungx Awaiting requested review from rleungx

Assignees

@AndreMouche AndreMouche

Labels

do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/5.3-cherry-pick

Projects

None yet

Milestone

v5.3.1

Development

Successfully merging this pull request may close these issues.

4 participants

@ti-srebot @ti-chi-bot @VelocityLight @AndreMouche