Skip to content

expression: do not derive filters containing null sensitive functions from outer join#27067

Merged
ti-chi-bot merged 3 commits intopingcap:masterfrom
eurekaka:prop_const
Aug 13, 2021
Merged

expression: do not derive filters containing null sensitive functions from outer join#27067
ti-chi-bot merged 3 commits intopingcap:masterfrom
eurekaka:prop_const

Conversation

@eurekaka
Copy link
Contributor

@eurekaka eurekaka commented Aug 10, 2021

What problem does this PR solve?

Issue Number: close #26758

Problem Summary:
Wrong query result.

What is changed and how it works?

What's Changed:
Do not derive filters containing null sensitive functions from outer join

How it Works:
Those derived null related functions would reduce the input of the join children, and hence the outer join results.

Check List

Tests

  • Unit test

Side effects

N/A

Documentation

N/A

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 10, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 10, 2021
@eurekaka
Copy link
Contributor Author

eurekaka commented Aug 10, 2021

/run-check_dev_2

@ichn-hu ichn-hu mentioned this pull request Aug 10, 2021
Closed
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 13, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 13, 2021
@eurekaka
Copy link
Contributor Author

eurekaka commented Aug 13, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 13, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 0016f3f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 13, 2021
@ti-chi-bot ti-chi-bot merged commit f791791 into pingcap:master Aug 13, 2021
@ti-srebot ti-srebot mentioned this pull request Aug 13, 2021
Merged
1 task
@ti-srebot
Copy link
Contributor

ti-srebot commented Aug 13, 2021

cherry pick to release-4.0 in PR #27193

@ti-srebot ti-srebot mentioned this pull request Aug 13, 2021
Merged
1 task
@ti-srebot
Copy link
Contributor

ti-srebot commented Aug 13, 2021

cherry pick to release-5.0 in PR #27194

@ti-srebot ti-srebot mentioned this pull request Aug 13, 2021
Merged
1 task
@ti-srebot
Copy link
Contributor

ti-srebot commented Aug 13, 2021

cherry pick to release-5.1 in PR #27195

@ti-srebot ti-srebot mentioned this pull request Aug 13, 2021
Merged
1 task
@ti-srebot
Copy link
Contributor

ti-srebot commented Aug 13, 2021

cherry pick to release-5.2 in PR #27196

@eurekaka eurekaka deleted the prop_const branch August 13, 2021 07:00
eurekaka added a commit to ti-srebot/tidb that referenced this pull request Aug 16, 2021
@eurekaka
cherry pick pingcap#27067 to release-5.2
7c715bc 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
ti-chi-bot pushed a commit that referenced this pull request Aug 16, 2021
@ti-srebot
expression: do not derive filters containing null sensitive functions…
a20edd2 
… from outer join (#27067) (#27196)
eurekaka added a commit to ti-srebot/tidb that referenced this pull request Aug 18, 2021
@eurekaka
cherry pick pingcap#27067 to release-5.1
75aca94
eurekaka added a commit to ti-srebot/tidb that referenced this pull request Aug 18, 2021
@eurekaka
cherry pick pingcap#27067 to release-5.0
0b7bc13
fzhedu pushed a commit to fzhedu/tidb that referenced this pull request Aug 30, 2021
@eurekaka @fzhedu
expression: do not derive filters containing null sensitive functions…
74a12ce 
… from outer join (pingcap#27067)
ti-chi-bot pushed a commit that referenced this pull request Aug 30, 2021
@ti-srebot
expression: do not derive filters containing null sensitive functions…
c6a143b 
… from outer join (#27067) (#27194)
eurekaka added a commit to ti-srebot/tidb that referenced this pull request Sep 6, 2021
@eurekaka
cherry pick pingcap#27067 to release-4.0
223957b
ti-chi-bot pushed a commit that referenced this pull request Sep 6, 2021
@ti-srebot
expression: do not derive filters containing null sensitive functions…
02c86ef 
… from outer join (#27067) (#27193)
ti-chi-bot pushed a commit that referenced this pull request Sep 14, 2021
@ti-srebot
expression: do not derive filters containing null sensitive functions…
376c94b 
… from outer join (#27067) (#27195)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qw4990 qw4990 qw4990 approved these changes

@winoros winoros winoros approved these changes

@time-and-fate time-and-fate Awaiting requested review from time-and-fate

Assignees

No one assigned

Labels

component/expression needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

query result is incorrect

5 participants

@eurekaka @ti-chi-bot @ti-srebot @qw4990 @winoros