expression: do not derive filters containing null sensitive functions from outer join (#27067)#27195
Merged
ti-chi-bot merged 2 commits intopingcap:release-5.1from Sep 14, 2021
Conversation
Member
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
Contributor
Author
|
/run-all-tests |
1 task
Contributor
Author
|
@eurekaka you're already a collaborator in bot's repo. |
28f9a14 to
75aca94
Compare
qw4990
approved these changes
Aug 18, 2021
winoros
approved these changes
Aug 18, 2021
Contributor
|
/merge |
Member
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 833565c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick #27067 to release-5.1
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/27195After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #26758
Problem Summary:
Wrong query result.
What is changed and how it works?
What's Changed:
Do not derive filters containing null sensitive functions from outer join
How it Works:
Those derived null related functions would reduce the input of the join children, and hence the outer join results.
Check List
Tests
Side effects
N/A
Documentation
N/A
Release note