Skip to content

planner: fix the unstable unit test TestAnalyzeIncremental#26460

Merged
ti-chi-bot merged 7 commits intopingcap:masterfrom
qw4990:fix-25013
Jul 23, 2021
Merged

planner: fix the unstable unit test TestAnalyzeIncremental#26460
ti-chi-bot merged 7 commits intopingcap:masterfrom
qw4990:fix-25013

Conversation

@qw4990
Copy link
Contributor

@qw4990 qw4990 commented Jul 22, 2021

What problem does this PR solve?

Issue Number: close #25013

Problem Summary: planner: fix the unstable unit test TestAnalyzeIncremental

Check List

Tests

  • Unit test

Release note

  • No release note

@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 22, 2021
@qw4990 qw4990 requested review from Reminiscent and time-and-fate and removed request for Reminiscent July 22, 2021 06:28
@github-actions github-actions bot added the sig/execution SIG execution label Jul 22, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 22, 2021
@ichn-hu ichn-hu mentioned this pull request Jul 22, 2021
Closed
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 23, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Reminiscent
  • rebelice

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 23, 2021
@qw4990
Copy link
Contributor Author

qw4990 commented Jul 23, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 23, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: fcba1e9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 23, 2021
@ti-chi-bot ti-chi-bot merged commit 95a40ac into pingcap:master Jul 23, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 23, 2021
@qw4990 @ti-srebot
cherry pick pingcap#26460 to release-4.0
42aefdc 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 23, 2021
Closed
1 task
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 23, 2021

cherry pick to release-4.0 in PR #26498

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 23, 2021
@qw4990 @ti-srebot
cherry pick pingcap#26460 to release-5.0
df7d747 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 23, 2021
Merged
1 task
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 23, 2021

cherry pick to release-5.0 in PR #26499

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 23, 2021
@qw4990 @ti-srebot
cherry pick pingcap#26460 to release-5.1
60e8044 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 23, 2021
Merged
1 task
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 23, 2021

cherry pick to release-5.1 in PR #26501

ti-chi-bot pushed a commit that referenced this pull request Sep 16, 2021
@ti-srebot
planner: fix the unstable unit test TestAnalyzeIncremental (#26460) (…
6f38e05 
…#26501)
ti-chi-bot pushed a commit that referenced this pull request Dec 19, 2021
@ti-srebot
planner: fix the unstable unit test TestAnalyzeIncremental (#26460) (…
c5ca06c 
…#26499)

close #25013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rebelice rebelice rebelice approved these changes

@time-and-fate time-and-fate Awaiting requested review from time-and-fate

+1 more reviewer

@Reminiscent Reminiscent Reminiscent approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 sig/execution SIG execution sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

data race in executor_test

5 participants

@qw4990 @ti-chi-bot @ti-srebot @rebelice @Reminiscent