Skip to content

planner: fix the unstable unit test TestAnalyzeIncremental (#26460)#26498

Closed
ti-srebot wants to merge 1 commit intopingcap:release-4.0from
ti-srebot:release-4.0-95a40ac3d411
Closed

planner: fix the unstable unit test TestAnalyzeIncremental (#26460)#26498
ti-srebot wants to merge 1 commit intopingcap:release-4.0from
ti-srebot:release-4.0-95a40ac3d411

Conversation

@ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jul 23, 2021 •
edited
Loading

cherry-pick #26460 to release-4.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/26498

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/26498:release-4.0-95a40ac3d411

What problem does this PR solve?

Issue Number: close #25013

Problem Summary: planner: fix the unstable unit test TestAnalyzeIncremental

Check List

Tests

  • Unit test

Release note

  • No release note

@qw4990 @ti-srebot
cherry pick pingcap#26460 to release-4.0
42aefdc 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 23, 2021

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 23, 2021

@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-srebot
Copy link
Contributor Author

ti-srebot commented Jul 23, 2021

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Jul 23, 2021
Merged
1 task
@ti-srebot ti-srebot added sig/execution SIG execution sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/4.0-cherry-pick type/bugfix This PR fixes a bug. labels Jul 23, 2021
@ti-srebot ti-srebot added this to the v4.0.14 milestone Jul 23, 2021
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Jul 23, 2021

@qw4990 you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 23, 2021
@xhebox
Copy link
Contributor

xhebox commented Aug 30, 2022

close for DMR version

@xhebox xhebox closed this Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rebelice rebelice Awaiting requested review from rebelice

@Reminiscent Reminiscent Awaiting requested review from Reminiscent

@time-and-fate time-and-fate Awaiting requested review from time-and-fate

Assignees

@qw4990 qw4990

Labels

do-not-merge/cherry-pick-not-approved sig/execution SIG execution sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/bugfix This PR fixes a bug. type/4.0-cherry-pick

Projects

None yet

Milestone

v4.0.14

Development

Successfully merging this pull request may close these issues.

4 participants

@ti-srebot @ti-chi-bot @xhebox @qw4990