Skip to content

*: remove useless FIXME tip in code#22970

Merged
ti-chi-bot merged 4 commits intopingcap:masterfrom
xhebox:sessfix
Feb 26, 2021
Merged

*: remove useless FIXME tip in code#22970
ti-chi-bot merged 4 commits intopingcap:masterfrom
xhebox:sessfix

Conversation

@xhebox
Copy link
Contributor

@xhebox xhebox commented Feb 26, 2021

Signed-off-by: xhe xw897002528@gmail.com

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary: Either RestoreStringSingleQuotes or RestoreStringDoubleQuotes can solve the issue. Doubles like ''/"" will be interpreted as one single character in the string.

Check List

Tests

  • Unit test
  • Integration test

Side effects

Release note

  • No release note

@xhebox
*: it is safe, remove the tip
83b7a48 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
Copy link
Contributor Author

xhebox commented Feb 26, 2021

/sig sql-infra

@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/sql-infra SIG: SQL Infra labels Feb 26, 2021
@xhebox
Copy link
Contributor Author

xhebox commented Feb 26, 2021

/label needs-cherry-pick-5.0-rc

@xhebox
Copy link
Contributor Author

xhebox commented Feb 26, 2021

/cc @wjhuang2016 @xiongjiwei

xhebox added a commit to ti-srebot/tidb that referenced this pull request Feb 26, 2021
@xhebox
*: cherry-pick pingcap#22970
f248dbd 
Signed-off-by: xhe <xw897002528@gmail.com>
wjhuang2016
wjhuang2016 reviewed Feb 26, 2021
View reviewed changes
Copy link
Member

@wjhuang2016 wjhuang2016 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@wjhuang2016
Copy link
Member

wjhuang2016 commented Feb 26, 2021

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 26, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 26, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • wjhuang2016
  • xiongjiwei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 26, 2021
@xhebox
Copy link
Contributor Author

xhebox commented Feb 26, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 26, 2021

@xhebox: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 26, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 83b7a48

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 26, 2021
@0xPoe
Copy link
Member

0xPoe commented Feb 26, 2021

/run-all-tests

@0xPoe
Copy link
Member

0xPoe commented Feb 26, 2021

@ti-chi-bot update this pr branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 26, 2021

@xhebox: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 03109ad into pingcap:master Feb 26, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Feb 26, 2021
@xhebox @ti-srebot
cherry pick pingcap#22970 to release-5.0-rc
dc8a42a 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Feb 26, 2021
Closed
@ti-srebot
Copy link
Contributor

ti-srebot commented Feb 26, 2021

cherry pick to release-5.0-rc in PR #22973

@xhebox xhebox deleted the sessfix branch April 2, 2021 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wjhuang2016 wjhuang2016 wjhuang2016 left review comments

+1 more reviewer

@xiongjiwei xiongjiwei xiongjiwei approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

sig/sql-infra SIG: SQL Infra size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@xhebox @wjhuang2016 @ti-chi-bot @0xPoe @ti-srebot @xiongjiwei