Skip to content

*: remove useless FIXME tip in code (#22970)#22973

Closed
ti-srebot wants to merge 1 commit intopingcap:release-5.0-rcfrom
ti-srebot:release-5.0-rc-03109adaadcb
Closed

*: remove useless FIXME tip in code (#22970)#22973
ti-srebot wants to merge 1 commit intopingcap:release-5.0-rcfrom
ti-srebot:release-5.0-rc-03109adaadcb

Conversation

@ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Feb 26, 2021 •
edited
Loading

cherry-pick #22970 to release-5.0-rc
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/22973

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/22973:release-5.0-rc-03109adaadcb

Signed-off-by: xhe xw897002528@gmail.com

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary: Either RestoreStringSingleQuotes or RestoreStringDoubleQuotes can solve the issue. Doubles like ''/"" will be interpreted as one single character in the string.

Check List

Tests

  • Unit test
  • Integration test

Side effects

Release note

  • No release note

@xhebox @ti-srebot
cherry pick pingcap#22970 to release-5.0-rc
dc8a42a 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Feb 26, 2021

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Feb 26, 2021
Merged
@ti-srebot ti-srebot added sig/sql-infra SIG: SQL Infra size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/5.0-rc-cherry-pick labels Feb 26, 2021
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Feb 26, 2021

@xhebox you're already a collaborator in bot's repo.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 9, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • xiongjiwei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 9, 2021
@wjhuang2016
Copy link
Member

wjhuang2016 commented Mar 9, 2021

There's no need to cherry-pick.

@xhebox
Copy link
Contributor

xhebox commented Mar 9, 2021

There's no need to cherry-pick.

5.0-rc is not a LTS version, right? Then I am fine with close it. BTW, I don't have permission to close the PR.

@xiongjiwei
Copy link
Contributor

xiongjiwei commented Mar 9, 2021

There's no need to cherry-pick.

5.0-rc is not a LTS version, right? Then I am fine with close it. BTW, I don't have permission to close the PR.

use /close can close PR

@xhebox
Copy link
Contributor

xhebox commented Mar 9, 2021

/close

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 9, 2021

@xhebox: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot closed this Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wjhuang2016 wjhuang2016 Awaiting requested review from wjhuang2016

1 more reviewer

@xiongjiwei xiongjiwei xiongjiwei approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@xhebox xhebox

Labels

sig/sql-infra SIG: SQL Infra size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ti-srebot @ti-chi-bot @wjhuang2016 @xhebox @xiongjiwei