Skip to content

*: rename tiflash fallback switch#22886

Merged
winoros merged 16 commits intopingcap:masterfrom
xuyifangreeneyes:enable-engine-fallback
Mar 12, 2021
Merged

*: rename tiflash fallback switch#22886
winoros merged 16 commits intopingcap:masterfrom
xuyifangreeneyes:enable-engine-fallback

Conversation

@xuyifangreeneyes
Copy link
Contributor

@xuyifangreeneyes xuyifangreeneyes commented Feb 23, 2021 •
edited
Loading

What problem does this PR solve?

Related PR: #22459

Rename TiFlash fallback switch.

What is changed and how it works?

What's Changed:

Use tidb_allow_fallback_to_tikv instead of tidb_enable_tiflash_fallback_tikv to control the behavior of TiFlash fallback, since there may be new engine types which also need fallback to TiKV in the future.

Related changes

Check List

Tests

  • Unit test
  • Integration test

Release note

  • replace tidb_enable_tiflash_fallback_tikv with tidb_allow_fallback_to_tikv to control the behavior of TiFlash fallback

@xuyifangreeneyes xuyifangreeneyes requested a review from a team as a code owner February 23, 2021 06:20
@xuyifangreeneyes xuyifangreeneyes requested review from XuHuaiyu and removed request for a team February 23, 2021 06:20
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 23, 2021
@xuyifangreeneyes
Copy link
Contributor Author

xuyifangreeneyes commented Feb 23, 2021

/run-all-tests

@xuyifangreeneyes
Copy link
Contributor Author

xuyifangreeneyes commented Feb 23, 2021

/cc @winoros

@ti-chi-bot ti-chi-bot requested a review from winoros February 23, 2021 06:22
@xuyifangreeneyes
Copy link
Contributor Author

xuyifangreeneyes commented Feb 23, 2021

/run-unit-test

@github-actions github-actions bot added sig/execution SIG execution sig/sql-infra SIG: SQL Infra labels Feb 23, 2021
@xuyifangreeneyes
Copy link
Contributor Author

xuyifangreeneyes commented Feb 24, 2021

/run-all-tests

1 similar comment
@xuyifangreeneyes
Copy link
Contributor Author

xuyifangreeneyes commented Feb 24, 2021

/run-all-tests

@xuyifangreeneyes
Copy link
Contributor Author

xuyifangreeneyes commented Feb 24, 2021

/run-tics-test

This was referenced Feb 24, 2021
Merged
Merged
@xuyifangreeneyes
Copy link
Contributor Author

xuyifangreeneyes commented Feb 26, 2021

PTAL @winoros @qw4990

@xuyifangreeneyes
Copy link
Contributor Author

xuyifangreeneyes commented Feb 26, 2021

/cc @qw4990

@ti-chi-bot ti-chi-bot requested a review from qw4990 February 26, 2021 08:02
winoros
winoros reviewed Mar 1, 2021
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 1, 2021

@winoros: Please use /LGTM instead of LGTM when you want to approve the pull request by comment.
If you use the GitHub review feature, please approve the PR directly, the comment will not take effect in the GitHub review feature.
If you have any qustions please refer to lgtm command help or lgtm plugin design.

If you have approved this PR, please ignore this reply. This reply is being used as a temporary reply during the migration of the new bot and will be removed on April 1.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@xuyifangreeneyes
Copy link
Contributor Author

xuyifangreeneyes commented Mar 2, 2021

/run-all-tests

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 7, 2021
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 10, 2021
@xuyifangreeneyes xuyifangreeneyes changed the title *: rename tidb_enable_tiflash_fallback_tikv to tidb_enable_engine_fallback *: rename tiflash fallback switch Mar 10, 2021
zz-jason
zz-jason reviewed Mar 12, 2021
View reviewed changes
@xuyifangreeneyes
Copy link
Contributor Author

xuyifangreeneyes commented Mar 12, 2021

/run-all-tests

@xuyifangreeneyes
Copy link
Contributor Author

xuyifangreeneyes commented Mar 12, 2021

/run-unit-test

@xuyifangreeneyes
Copy link
Contributor Author

xuyifangreeneyes commented Mar 12, 2021

/run-all-tests

zz-jason
zz-jason approved these changes Mar 12, 2021
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 12, 2021

@zz-jason: Please use /LGTM instead of LGTM when you want to approve the pull request by comment.
If you use the GitHub review feature, please approve the PR directly, the comment will not take effect in the GitHub review feature.
If you have any qustions please refer to lgtm command help or lgtm plugin design.

If you have approved this PR, please ignore this reply. This reply is being used as a temporary reply during the migration of the new bot and will be removed on April 1.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 12, 2021
@winoros
Copy link
Member

winoros commented Mar 12, 2021

/lgtm

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 12, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • winoros
  • zz-jason

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 12, 2021
@zz-jason
Copy link
Member

zz-jason commented Mar 12, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 12, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: f81e5d7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 12, 2021
@xuyifangreeneyes
Copy link
Contributor Author

xuyifangreeneyes commented Mar 12, 2021

/run-tics-test

1 similar comment
@winoros
Copy link
Member

winoros commented Mar 12, 2021

/run-tics-test

@xuyifangreeneyes
Copy link
Contributor Author

xuyifangreeneyes commented Mar 12, 2021

/run-tics-test

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 12, 2021

@xuyifangreeneyes: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@winoros
Copy link
Member

winoros commented Mar 12, 2021

The leak would be fixed by #23288

@winoros winoros merged commit 035c15f into pingcap:master Mar 12, 2021
This was referenced Mar 23, 2021
Merged
Merged
@xuyifangreeneyes xuyifangreeneyes mentioned this pull request Apr 22, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zz-jason zz-jason zz-jason approved these changes

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

@qw4990 qw4990 Awaiting requested review from qw4990

@winoros winoros Awaiting requested review from winoros

Assignees

No one assigned

Labels

priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/execution SIG execution sig/sql-infra SIG: SQL Infra size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xuyifangreeneyes @ti-chi-bot @winoros @zz-jason