Skip to content

system variable: add tidb_allow_fallback_to_tikv#5484

Merged
yikeke merged 13 commits intopingcap:masterfrom
xuyifangreeneyes:tiflash-fallback-tikv
Mar 23, 2021
Merged

system variable: add tidb_allow_fallback_to_tikv#5484
yikeke merged 13 commits intopingcap:masterfrom
xuyifangreeneyes:tiflash-fallback-tikv

Conversation

@xuyifangreeneyes
Copy link
Contributor

@xuyifangreeneyes xuyifangreeneyes commented Feb 3, 2021 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add tidb_allow_fallback_to_tikv into system variables.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@CLAassistant
Copy link

CLAassistant commented Feb 3, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-srebot ti-srebot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Feb 3, 2021
This was referenced Feb 3, 2021
Merged
Merged
@xuyifangreeneyes xuyifangreeneyes mentioned this pull request Feb 23, 2021
Merged
@xuyifangreeneyes xuyifangreeneyes changed the title system variable: add tidb_enable_tiflash_fallback_tikv system variable: add tidb_enable_engine_fallback Feb 24, 2021
@xuyifangreeneyes xuyifangreeneyes marked this pull request as ready for review February 24, 2021 07:58
@TomShawn TomShawn requested review from qw4990 and winoros February 24, 2021 12:01
@TomShawn
Copy link
Contributor

TomShawn commented Feb 24, 2021

@xuyifangreeneyes Could you specify from which version this variable is introduced?

@TomShawn TomShawn added size/small Changes of a small size. status/PTAL This PR is ready for reviewing. translation/doing This PR’s assignee is translating this PR. labels Feb 24, 2021
@ti-srebot
Copy link
Contributor

ti-srebot commented Feb 26, 2021

@qw4990, @winoros, PTAL.

2 similar comments
@ti-srebot
Copy link
Contributor

ti-srebot commented Feb 28, 2021

@qw4990, @winoros, PTAL.

@ti-srebot
Copy link
Contributor

ti-srebot commented Mar 3, 2021

@qw4990, @winoros, PTAL.

@ti-chi-bot ti-chi-bot added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Mar 11, 2021
@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/small Changes of a small size. labels Mar 15, 2021
@xuyifangreeneyes xuyifangreeneyes changed the title system variable: add tidb_enable_engine_fallback system variable: add tidb_allow_fallback_to_tikv Mar 15, 2021
@qiancai
Copy link
Collaborator

qiancai commented Mar 22, 2021

/lgtm

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 22, 2021

@qiancai: /lgtm is only allowed for the reviewers in list.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

TomShawn
TomShawn reviewed Mar 23, 2021
View reviewed changes
TomShawn
TomShawn reviewed Mar 23, 2021
View reviewed changes
@TomShawn
Copy link
Contributor

TomShawn commented Mar 23, 2021

/status require-change

@ti-chi-bot ti-chi-bot added the status/require-change Needs the author to address comments. label Mar 23, 2021
xuyifangreeneyes and others added 4 commits March 23, 2021 13:35
@xuyifangreeneyes @TomShawn
Update system-variables.md
af0ee46 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@xuyifangreeneyes @TomShawn
Update system-variables.md
17d5a4e 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@xuyifangreeneyes
upd
16896c3
@xuyifangreeneyes
upd
4da19cf
@xuyifangreeneyes
Copy link
Contributor Author

xuyifangreeneyes commented Mar 23, 2021

@TomShawn PTAL

@TomShawn
Copy link
Contributor

TomShawn commented Mar 23, 2021

/remove-status require-change

@ti-chi-bot ti-chi-bot removed the status/require-change Needs the author to address comments. label Mar 23, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Mar 23, 2021

/lgtm

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 23, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 23, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Mar 23, 2021

/label require-LGT1

@ti-chi-bot ti-chi-bot added the require-LGT1 Indicates that the PR requires an LGTM. label Mar 23, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Mar 23, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 23, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 4da19cf

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 23, 2021
@yikeke
Copy link
Contributor

yikeke commented Mar 23, 2021

/merge

@yikeke yikeke merged commit 34f72ea into pingcap:master Mar 23, 2021
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Mar 23, 2021
@xuyifangreeneyes @ti-srebot
cherry pick pingcap#5484 to release-5.0
ede6fc6 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 23, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Mar 23, 2021

cherry pick to release-5.0 in PR #5801

ti-chi-bot pushed a commit that referenced this pull request Mar 24, 2021
@ti-srebot
system variable: add tidb_allow_fallback_to_tikv (#5484) (#5801)
bf070aa
@ti-srebot ti-srebot mentioned this pull request Mar 25, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qw4990 qw4990 qw4990 approved these changes

@winoros winoros winoros left review comments

@qiancai qiancai qiancai left review comments

+1 more reviewer

@TomShawn TomShawn TomShawn left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@xuyifangreeneyes xuyifangreeneyes

Labels

first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v5.0 This PR/issue applies to TiDB v5.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@xuyifangreeneyes @CLAassistant @TomShawn @ti-srebot @ti-chi-bot @qiancai @Joyinqin @yikeke @qw4990 @winoros