Skip to content

test: work around goroutine leak#23288

Merged
ti-chi-bot merged 24 commits intopingcap:masterfrom
fzhedu:killMpp1
Mar 12, 2021
Merged

test: work around goroutine leak#23288
ti-chi-bot merged 24 commits intopingcap:masterfrom
fzhedu:killMpp1

Conversation

@fzhedu
Copy link
Contributor

@fzhedu fzhedu commented Mar 12, 2021

What problem does this PR solve?

Issue Number: close #xxx

avoid goroutine leak from https://internal.pingcap.net/idc-jenkins/blue/rest/organizations/jenkins/pipelines/tidb_ghpr_unit_test/runs/67445/nodes/100/steps/319/log/?start=0
Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed: work around this leak, fix this later with @hanfei1991 .

How it Works:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

Release note

  • No release note

@fzhedu fzhedu requested review from hanfei1991 and lzmhhh123 March 12, 2021 09:59
@fzhedu fzhedu requested a review from a team as a code owner March 12, 2021 09:59
@ti-chi-bot ti-chi-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 12, 2021
@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 12, 2021
@fzhedu fzhedu requested a review from winoros March 12, 2021 10:04
@fzhedu fzhedu changed the title test: Kill mpp1 test: work around goroutine leak Mar 12, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 12, 2021
@winoros winoros mentioned this pull request Mar 12, 2021
Merged
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 12, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lzmhhh123
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 12, 2021
@fzhedu
Copy link
Contributor Author

fzhedu commented Mar 12, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 12, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 639de1e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 12, 2021
@fzhedu
Copy link
Contributor Author

fzhedu commented Mar 12, 2021

/run-integration-copr-test

@github-actions github-actions bot added the sig/execution SIG execution label Mar 12, 2021
hanfei1991
hanfei1991 approved these changes Mar 12, 2021
View reviewed changes
Copy link
Member

@hanfei1991 hanfei1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@fzhedu
Copy link
Contributor Author

fzhedu commented Mar 12, 2021

/run-sqllogic-test-2

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 12, 2021

@fzhedu: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 0b68d8a into pingcap:master Mar 12, 2021
@fzhedu fzhedu mentioned this pull request Mar 15, 2021
Merged
@ti-srebot ti-srebot mentioned this pull request Mar 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@winoros winoros winoros approved these changes

@hanfei1991 hanfei1991 hanfei1991 approved these changes

+1 more reviewer

@lzmhhh123 lzmhhh123 lzmhhh123 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

sig/execution SIG execution size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fzhedu @ti-chi-bot @winoros @hanfei1991 @lzmhhh123