Skip to content

cmd: migrate the Execute interface to ExecuteInternal in cmd package#22647

Merged
ti-srebot merged 6 commits intopingcap:masterfrom
AilinKid:fix_cmd_package
Feb 2, 2021
Merged

cmd: migrate the Execute interface to ExecuteInternal in cmd package#22647
ti-srebot merged 6 commits intopingcap:masterfrom
AilinKid:fix_cmd_package

Conversation

@AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Feb 1, 2021

Signed-off-by: AilinKid 314806019@qq.com

What problem does this PR solve?

Issue Number: part close #https://github.com/pingcap/tidb-test/issues/1152

What is changed and how it works?

What's Changed:

Make the code in cmd package get ride of original Execute API which may have some security risks.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
the bench test can only be tested in the real cluster.
1: start a cluster
2: run the bench test main.

Release note

  • cmd: migrate the Execute interface to ExecuteInternal in cmd package.

@AilinKid
migrate the Execute interface to ExecuteInternal in cmd package
a22f719 
Signed-off-by: AilinKid <314806019@qq.com>
@AilinKid
.
ff9406e 
Signed-off-by: AilinKid <314806019@qq.com>
@morgo
Copy link
Contributor

morgo commented Feb 1, 2021

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 1, 2021
xhebox
xhebox reviewed Feb 2, 2021
View reviewed changes
Copy link
Contributor

@xhebox xhebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Feb 2, 2021
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Feb 2, 2021
@xhebox
Copy link
Contributor

xhebox commented Feb 2, 2021

/label needs-cherry-pick-4.0

@xhebox
Copy link
Contributor

xhebox commented Feb 2, 2021

/label needs-cherry-pick-5.0-rc

@xhebox
Copy link
Contributor

xhebox commented Feb 2, 2021

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 2, 2021
@ti-srebot
Copy link
Contributor

ti-srebot commented Feb 2, 2021

/run-all-tests

@ti-srebot ti-srebot merged commit d572312 into pingcap:master Feb 2, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Feb 2, 2021
@AilinKid @ti-srebot
cherry pick pingcap#22647 to release-4.0
e75760f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Feb 2, 2021
Closed
@ti-srebot
Copy link
Contributor

ti-srebot commented Feb 2, 2021

cherry pick to release-4.0 in PR #22660

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Feb 2, 2021
@AilinKid @ti-srebot
cherry pick pingcap#22647 to release-5.0-rc
eb9d12a 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Feb 2, 2021
Closed
@ti-srebot
Copy link
Contributor

ti-srebot commented Feb 2, 2021

cherry pick to release-5.0-rc in PR #22661

@xhebox xhebox mentioned this pull request Feb 3, 2021
Merged
@AilinKid AilinKid mentioned this pull request Feb 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xhebox xhebox xhebox left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@morgo morgo Awaiting requested review from morgo

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

Assignees

No one assigned

Labels

status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AilinKid @morgo @xhebox @ti-srebot