Skip to content

cmd: migrate the Execute interface to ExecuteInternal in cmd package (#22647)#22660

Closed
ti-srebot wants to merge 1 commit intopingcap:release-4.0from
ti-srebot:release-4.0-d57231205fb3
Closed

cmd: migrate the Execute interface to ExecuteInternal in cmd package (#22647)#22660
ti-srebot wants to merge 1 commit intopingcap:release-4.0from
ti-srebot:release-4.0-d57231205fb3

Conversation

@ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Feb 2, 2021

cherry-pick #22647 to release-4.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/22660

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/22660:release-4.0-d57231205fb3

Signed-off-by: AilinKid 314806019@qq.com

What problem does this PR solve?

Issue Number: part close #https://github.com/pingcap/tidb-test/issues/1152

What is changed and how it works?

What's Changed:

Make the code in cmd package get ride of original Execute API which may have some security risks.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
the bench test can only be tested in the real cluster.
1: start a cluster
2: run the bench test main.

Release note

  • cmd: migrate the Execute interface to ExecuteInternal in cmd package.

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@AilinKid you're already a collaborator in bot's repo.

@AilinKid
Copy link
Contributor

cmd package is only used to bench, it's not necessary here.

@AilinKid AilinKid closed this Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants