Skip to content

executor: open childExec during execution for UnionExec#21561

Merged
XuHuaiyu merged 18 commits intopingcap:masterfrom
XuHuaiyu:issue21441_2
Dec 9, 2020
Merged

executor: open childExec during execution for UnionExec#21561
XuHuaiyu merged 18 commits intopingcap:masterfrom
XuHuaiyu:issue21441_2

Conversation

@XuHuaiyu
Copy link
Contributor

@XuHuaiyu XuHuaiyu commented Dec 8, 2020

What problem does this PR solve?

Issue Number: close #21441

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • No release note.

@XuHuaiyu XuHuaiyu added type/enhancement The issue or PR belongs to an enhancement. status/WIP component/executor labels Dec 8, 2020
@XuHuaiyu XuHuaiyu requested a review from a team as a code owner December 8, 2020 09:23
@XuHuaiyu XuHuaiyu requested review from qw4990 and removed request for a team and qw4990 December 8, 2020 09:23
@github-actions github-actions bot added the sig/execution SIG execution label Dec 8, 2020
@XuHuaiyu
Copy link
Contributor Author

XuHuaiyu commented Dec 8, 2020

/run-all-tests

@XuHuaiyu
Copy link
Contributor Author

XuHuaiyu commented Dec 8, 2020

/run-all-tests

@XuHuaiyu XuHuaiyu requested a review from wshwsh12 December 8, 2020 09:59
@XuHuaiyu
Copy link
Contributor Author

XuHuaiyu commented Dec 8, 2020

/run-unit-tests

@XuHuaiyu
Copy link
Contributor Author

XuHuaiyu commented Dec 8, 2020

/run-all-tests

@XuHuaiyu
Copy link
Contributor Author

XuHuaiyu commented Dec 8, 2020

/run-check_dev_2

@XuHuaiyu
Copy link
Contributor Author

XuHuaiyu commented Dec 8, 2020

/run-all-tests

@XuHuaiyu
Copy link
Contributor Author

XuHuaiyu commented Dec 9, 2020

/run-all-tests

wshwsh12
wshwsh12 reviewed Dec 9, 2020
View reviewed changes
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 9, 2020
@XuHuaiyu
Copy link
Contributor Author

XuHuaiyu commented Dec 9, 2020

/run-all-tests

lysu
lysu approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Dec 9, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Dec 9, 2020
@XuHuaiyu
Copy link
Contributor Author

XuHuaiyu commented Dec 9, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 9, 2020
@ti-srebot
Copy link
Contributor

ti-srebot commented Dec 9, 2020

/run-all-tests

@ti-srebot
Copy link
Contributor

ti-srebot commented Dec 9, 2020

@XuHuaiyu merge failed.

@XuHuaiyu XuHuaiyu merged commit 0eb8ff9 into pingcap:master Dec 9, 2020
@XuHuaiyu XuHuaiyu deleted the issue21441_2 branch December 9, 2020 07:10
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Dec 9, 2020
@XuHuaiyu @ti-srebot
cherry pick pingcap#21561 to release-4.0
98ff262 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Dec 9, 2020
Merged
@ti-srebot
Copy link
Contributor

ti-srebot commented Dec 9, 2020

cherry pick to release-4.0 in PR #21598

XuHuaiyu pushed a commit that referenced this pull request Dec 9, 2020
@ti-srebot
executor: open childExec during execution for UnionExec (#21561) (#21598
c3468f1 
)
This was referenced Dec 9, 2020
Merged
Merged
@ti-srebot ti-srebot mentioned this pull request Dec 10, 2020
Merged
XuHuaiyu added a commit to XuHuaiyu/tidb that referenced this pull request Mar 12, 2021
@XuHuaiyu
Revert "executor: open childExec during execution for UnionExec (ping…
af5934d 
…cap#21561)"

This reverts commit 0eb8ff9.
XuHuaiyu added a commit that referenced this pull request Mar 12, 2021
@XuHuaiyu
Revert "executor: open childExec during execution for UnionExec (#21561…
30da0a1 
…) (#23276)
XuHuaiyu added a commit to XuHuaiyu/tidb that referenced this pull request May 26, 2021
@XuHuaiyu
executor: open childExec during execution for UnionExec (pingcap#21561)
b7c951b
@XuHuaiyu XuHuaiyu mentioned this pull request May 26, 2021
Merged
@ti-srebot ti-srebot mentioned this pull request Jun 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wshwsh12 wshwsh12 wshwsh12 left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

+1 more reviewer

@lysu lysu lysu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component/executor sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support lazy open union children

4 participants

@XuHuaiyu @ti-srebot @lysu @wshwsh12