Skip to content

executor: open childExec during execution for UnionExec (#21561)#21598

Merged
XuHuaiyu merged 3 commits intopingcap:release-4.0from
ti-srebot:release-4.0-0eb8ff97bc11
Dec 9, 2020
Merged

executor: open childExec during execution for UnionExec (#21561)#21598
XuHuaiyu merged 3 commits intopingcap:release-4.0from
ti-srebot:release-4.0-0eb8ff97bc11

Conversation

@ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Dec 9, 2020

cherry-pick #21561 to release-4.0

What problem does this PR solve?

Issue Number: close #21441

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • No release note.

@XuHuaiyu @ti-srebot
cherry pick pingcap#21561 to release-4.0
98ff262 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Dec 9, 2020

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Dec 9, 2020
Merged
@ti-srebot ti-srebot added component/executor sig/execution SIG execution type/4.0-cherry-pick type/enhancement The issue or PR belongs to an enhancement. labels Dec 9, 2020
@ti-srebot ti-srebot requested review from lysu and wshwsh12 December 9, 2020 07:11
@ti-srebot ti-srebot added this to the 4.0.0 milestone Dec 9, 2020
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Dec 9, 2020

@XuHuaiyu you're already a collaborator in bot's repo.

@lysu
Copy link
Contributor

lysu commented Dec 9, 2020

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 9, 2020
@XuHuaiyu
Copy link
Contributor

XuHuaiyu commented Dec 9, 2020

/run-all-tests

wshwsh12
wshwsh12 approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 9, 2020
@jebter
Copy link

jebter commented Dec 9, 2020

/merge

@ti-srebot
Copy link
Contributor Author

ti-srebot commented Dec 9, 2020

Sorry @jebter, this branch cannot be merged without an approval of release maintainers.

@ti-srebot ti-srebot added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Dec 9, 2020
@XuHuaiyu XuHuaiyu merged commit c3468f1 into pingcap:release-4.0 Dec 9, 2020
@XuHuaiyu XuHuaiyu deleted the release-4.0-0eb8ff97bc11 branch December 9, 2020 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@wshwsh12 wshwsh12 wshwsh12 approved these changes

@lysu lysu Awaiting requested review from lysu

Assignees

@XuHuaiyu XuHuaiyu

Labels

component/executor sig/execution SIG execution status/LGT3 The PR has already had 3 LGTM. type/enhancement The issue or PR belongs to an enhancement. type/4.0-cherry-pick

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@ti-srebot @lysu @XuHuaiyu @jebter @wshwsh12